Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[website] Fix broken website for master version #19945

Merged
merged 5 commits into from
Feb 24, 2021
Merged

Conversation

waytrue17
Copy link
Contributor

@waytrue17 waytrue17 commented Feb 23, 2021

Description

Fix broken website for master version described in #19943. The issue is due to the format of license header introduced by #19743, which blocks the pages from building by Jekyll:

<!---
  Licensed to the Apache Software Foundation (ASF) 
  ....
-->
---
layout: default
---

This PR attempts to fix the broken website by rearranging the license format.

Checklist

Essentials

  • PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage
  • Code is well-documented

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@mxnet-bot
Copy link

Hey @waytrue17 , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [unix-gpu, unix-cpu, windows-cpu, edge, clang, website, centos-gpu, centos-cpu, sanity, miscellaneous, windows-gpu]


Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@lanking520 lanking520 added the pr-awaiting-testing PR is reviewed and waiting CI build and test label Feb 23, 2021
@waytrue17
Copy link
Contributor Author

@ys2843 @szha @leezu Can you please review?

Copy link
Contributor

@Zha0q1 Zha0q1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sandeep-krishnamurthy
Copy link
Contributor

Thank you.

@lanking520 lanking520 added pr-work-in-progress PR is still work in progress and removed pr-awaiting-testing PR is reviewed and waiting CI build and test labels Feb 24, 2021
@waytrue17 waytrue17 changed the title [website] Fix broken website for master version [WIP] Fix broken website for master version Feb 24, 2021
@waytrue17 waytrue17 changed the title [WIP] Fix broken website for master version [website] Fix broken website for master version Feb 24, 2021
@waytrue17
Copy link
Contributor Author

@mxnet-bot run ci [windows-cpu]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [windows-cpu]

@lanking520 lanking520 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-awaiting-merge Review and CI is complete. Ready to Merge and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Feb 24, 2021
Copy link
Contributor

@josephevans josephevans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks Wei!

@Zha0q1 Zha0q1 merged commit 2ddbf88 into apache:master Feb 24, 2021
@leezu
Copy link
Contributor

leezu commented Feb 24, 2021

@waytrue17 any ideas how to update our CI to fail if a PR introduces problems similar to #19743?

@waytrue17 waytrue17 deleted the web-fix branch February 24, 2021 18:56
@ys2843
Copy link
Contributor

ys2843 commented Feb 24, 2021

could add a snapshot check in CI?

josephevans pushed a commit to josephevans/mxnet that referenced this pull request Dec 21, 2021
* fix website

* fix header

* fix index

* remove locall test

* fix main.scss

Co-authored-by: Wei Chu <[email protected]>
josephevans pushed a commit to josephevans/mxnet that referenced this pull request Dec 21, 2021
* fix website

* fix header

* fix index

* remove locall test

* fix main.scss

Co-authored-by: Wei Chu <[email protected]>
waytrue17 added a commit to waytrue17/incubator-mxnet that referenced this pull request Dec 21, 2021
* fix website

* fix header

* fix index

* remove locall test

* fix main.scss

Co-authored-by: Wei Chu <[email protected]>
@waytrue17 waytrue17 mentioned this pull request Dec 21, 2021
6 tasks
josephevans added a commit that referenced this pull request Dec 22, 2021
* fix website

* fix header

* fix index

* remove locall test

* fix main.scss

Co-authored-by: Wei Chu <[email protected]>

Co-authored-by: waytrue17 <[email protected]>
Co-authored-by: Wei Chu <[email protected]>
josephevans added a commit that referenced this pull request Dec 22, 2021
…from master (#20785)

* [v1.9.x] Fix CD for pypi wheel version (#20782)

* Change env variable used to detect whether it's a release build or not. RELEASE_BUILD is already setup in the CD pipeline.

* Refine how variable is compared to trigger release builds.

* Check for 'true' exclusively, to prevent unwanted release builds.

* Make sure we pass any environment variables on the build.py command line to the docker run command.

* [v1.9.x] Fix aarch64 cd pipeline (#20783)

* Add wheel to installed pip packages on aarch64, so we can build the wheel in the CD pipeline.

* Better support for aarch64 docker container cache.

* Only import machine() function from platform module, as platform variable is already widely used.

* Only build containers with aarch64 in name on aarch64.

* Make all arch defaults to local machine type.

* Retry getting test data to prevent CI tests from failing - increase connect timeout from 10 to 60sec, increase retry delay from 0 (setting duplicated) to 30, increase retry attempts to 5.

* Update website for v1.9.x branch. (#20786)

* [website] Fix broken website for master version  (#19945)

* fix website

* fix header

* fix index

* remove locall test

* fix main.scss

Co-authored-by: Wei Chu <[email protected]>

Co-authored-by: waytrue17 <[email protected]>
Co-authored-by: Wei Chu <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr-awaiting-merge Review and CI is complete. Ready to Merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants