Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[v1.x] CI fixes to make more stable and upgradable #19895

Merged
merged 11 commits into from
Feb 16, 2021
Merged

[v1.x] CI fixes to make more stable and upgradable #19895

merged 11 commits into from
Feb 16, 2021

Commits on Feb 13, 2021

  1. Test moving pipelines from p3 to g4.

    Joe Evans committed Feb 13, 2021
    Configuration menu
    Copy the full SHA
    7c64a60 View commit details
    Browse the repository at this point in the history

  2. Remove fallback codecov command - the existing (first) command works … 

    …and the second always fails a few times before finally succeeding (and also doesn't support the -P parameter, which causes an error.)
    Joe Evans committed Feb 13, 2021
    Configuration menu
    Copy the full SHA
    c682008 View commit details
    Browse the repository at this point in the history

  3. Stop using docker python client, since it still doesn't support lates… 

    …t nvidia 'gpus' attribute. Switch to using subprocess calls using list parameter (to avoid shell injections).

See docker/docker-py#2395
    Joe Evans committed Feb 13, 2021
    Configuration menu
    Copy the full SHA
    34ff9fc View commit details
    Browse the repository at this point in the history

  4. Remove old files.

    Joe Evans committed Feb 13, 2021
    Configuration menu
    Copy the full SHA
    af669a8 View commit details
    Browse the repository at this point in the history

  5. Fix comment

    Joe Evans committed Feb 13, 2021
    Configuration menu
    Copy the full SHA
    eb68b60 View commit details
    Browse the repository at this point in the history

  6. Set default environment variables

    Joe Evans committed Feb 13, 2021
    Configuration menu
    Copy the full SHA
    544ce51 View commit details
    Browse the repository at this point in the history

  7. Fix GPU syntax.

    Joe Evans committed Feb 13, 2021
    Configuration menu
    Copy the full SHA
    35b91e9 View commit details
    Browse the repository at this point in the history

  8. Use subprocess.run and redirect output to stdout, don't run docker in… 

    … interactive mode.
    Joe Evans committed Feb 13, 2021
    Configuration menu
    Copy the full SHA
    a2a667d View commit details
    Browse the repository at this point in the history

  9. Check if codecov works without providing parameters now.

    Joe Evans committed Feb 13, 2021
    Configuration menu
    Copy the full SHA
    c5352c4 View commit details
    Browse the repository at this point in the history

  10. Send docker stderr to sys.stderr

    Joe Evans committed Feb 13, 2021
    Configuration menu
    Copy the full SHA
    5412c8b View commit details
    Browse the repository at this point in the history

  11. Support both nvidia-docker configurations, first try '--gpus all', an… 

    …d if that fails, then try '--runtime nvidia'.
    Joe Evans committed Feb 13, 2021
    Configuration menu
    Copy the full SHA
    115fd3e View commit details
    Browse the repository at this point in the history