This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
[BUGFIX] fix #18938, #18939, #18940 #19833
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @r3stl355 , Thanks for submitting the PR
CI supported jobs: [clang, windows-gpu, sanity, miscellaneous, centos-cpu, centos-gpu, unix-gpu, website, unix-cpu, edge, windows-cpu] Note: |
lanking520
added
pr-awaiting-testing
lanking520
added
pr-awaiting-testing
|
@mxnet-bot run ci [unix-cpu, miscellaneous] |
|
Jenkins CI successfully triggered : [unix-cpu, miscellaneous] |
lanking520
added
pr-awaiting-testing
lanking520
added
pr-awaiting-testing
r3stl355
changed the title
leezu
approved these changes
Feb 7, 2021
lanking520
added
pr-awaiting-merge
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #18938, ##18939 and ##18940
Checklist
Essentials
Changes
Return early if zero-sized dimension is used. Added test to
test_operator.pyComments
One caveat - for the solution to work NumPy shape semantics must be used as shown in the test, otherwise the shape's zero-sized dimension of the output gets converted to 'unknown' dimension in the call to
[src.common.utils.h]::ConvertToNumpyShapewhich in turn will throw an error about unknown shape. I think it's alright to use NumPy shape semantics because the input is using NumPy semantics but if not then this will require a much bigger fix.