This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6.8k
[v1.x][BUGFIX] Impose a plain format for concat's output when oneDNN would use padding #19735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hey @PawelGlomski-Intel , Thanks for submitting the PR
CI supported jobs: [website, centos-gpu, sanity, windows-gpu, miscellaneous, clang, windows-cpu, centos-cpu, unix-cpu, unix-gpu, edge] Note: |
PawelGlomski-Intel
force-pushed
the
concatFix
branch
from
January 12, 2021 09:27
b60f5b4
to
0a9c7e7
Compare
PawelGlomski-Intel
changed the title
[v1.x][BUGFIX][WIP] Impose a plain format for concat's output when oneDNN would use padding
[v1.x][BUGFIX] Impose a plain format for concat's output when oneDNN would use padding
Jan 12, 2021
lanking520
added
pr-awaiting-testing
PR is reviewed and waiting CI build and test
pr-awaiting-review
PR is waiting for code review
and removed
pr-work-in-progress
PR is still work in progress
pr-awaiting-testing
PR is reviewed and waiting CI build and test
labels
Jan 12, 2021
PawelGlomski-Intel
force-pushed
the
concatFix
branch
from
January 14, 2021 09:56
0a9c7e7
to
76018df
Compare
PawelGlomski-Intel
requested review from
aaronmarkham,
anirudh2290,
eric-haibin-lin,
marcoabreu,
szha and
thirdwing
as code owners
January 14, 2021 09:56
PawelGlomski-Intel
force-pushed
the
concatFix
branch
from
January 14, 2021 09:57
76018df
to
9aef93e
Compare
lanking520
added
pr-awaiting-testing
PR is reviewed and waiting CI build and test
and removed
pr-awaiting-review
PR is waiting for code review
labels
Jan 14, 2021
Sorry for incidental review requests, I pushed a wrong branch |
lanking520
added
pr-work-in-progress
PR is still work in progress
pr-awaiting-testing
PR is reviewed and waiting CI build and test
and removed
pr-awaiting-testing
PR is reviewed and waiting CI build and test
pr-work-in-progress
PR is still work in progress
labels
Jan 14, 2021
lanking520
added
pr-awaiting-review
PR is waiting for code review
pr-work-in-progress
PR is still work in progress
and removed
pr-awaiting-testing
PR is reviewed and waiting CI build and test
pr-awaiting-review
PR is waiting for code review
labels
Jan 14, 2021
@mxnet-bot run ci [unix-gpu] |
Jenkins CI successfully triggered : [unix-gpu] |
lanking520
added
pr-awaiting-testing
PR is reviewed and waiting CI build and test
pr-work-in-progress
PR is still work in progress
and removed
pr-work-in-progress
PR is still work in progress
pr-awaiting-testing
PR is reviewed and waiting CI build and test
labels
Jan 14, 2021
@mxnet-bot run ci [unix-gpu] |
Jenkins CI successfully triggered : [unix-gpu] |
lanking520
added
pr-awaiting-testing
PR is reviewed and waiting CI build and test
pr-awaiting-review
PR is waiting for code review
and removed
pr-work-in-progress
PR is still work in progress
pr-awaiting-testing
PR is reviewed and waiting CI build and test
labels
Jan 18, 2021
@PatricZhao, @szha could you please review this? |
Thanks for the fix! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Right now, oneDNN may choose a blocked format for the output of concat, in cases that may require additional padding (thus more memory). In (de)convolution we make sure to only select a primitive_desc which has the expected (from tensor size) memory size requirements, so the same has to be done in this case.
Unlike convolution's, concat's primitive_desc does not support iteration over multiple implementations, so here I manually impose a plain format when oneDNN would choose a blocked one with padding.
Resolves #19586
Checklist
Essentials
Changes