Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

use CC=gcc-7 CXX=g++-7 for all unix CI builds #19701

Merged
merged 3 commits into from
Dec 23, 2020

Conversation

mseth10
Copy link
Contributor

@mseth10 mseth10 commented Dec 21, 2020

Description

This PR reverts gcc version update (from gcc-7 to gcc-8) for unix CI builds made in afc76b0. gcc8+ is known to cause memory issues #19623 #18501 . We did a RFC #19688 for the same, and as per community feedback reverting the gcc version back to gcc-7 until we fix the root cause.

We need to install gcc-7 explicitly now as ubuntu version has been upgraded by the same commit from 18 to 20. While ubuntu18 came with gcc-7 as default, ubuntu20 comes with gcc-9.

Also, removing apt-get install cmake as pip3 install cmake already exists. Once tensorrt supports ubuntu 20.04, we can drop the 18.04 image and remove the pip3 installation in favor of apt (as apt install on 20.04 provides a recent enough cmake).

@mxnet-bot
Copy link

Hey @mseth10 , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [windows-cpu, clang, miscellaneous, edge, unix-cpu, unix-gpu, website, centos-gpu, windows-gpu, centos-cpu, sanity]


Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@lanking520 lanking520 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-awaiting-testing PR is reviewed and waiting CI build and test labels Dec 21, 2020
@leezu
Copy link
Contributor

leezu commented Dec 21, 2020

You need to install gcc-7

@lanking520 lanking520 added pr-awaiting-testing PR is reviewed and waiting CI build and test and removed pr-work-in-progress PR is still work in progress labels Dec 22, 2020
@lanking520 lanking520 added pr-awaiting-review PR is waiting for code review and removed pr-awaiting-testing PR is reviewed and waiting CI build and test labels Dec 23, 2020
@mseth10 mseth10 merged commit dcd7e80 into apache:master Dec 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr-awaiting-review PR is waiting for code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants