This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
use CC=gcc-7 CXX=g++-7 for all unix CI builds #19701
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR reverts gcc version update (from
gcc-7
togcc-8
) for unix CI builds made in afc76b0. gcc8+ is known to cause memory issues #19623 #18501 . We did a RFC #19688 for the same, and as per community feedback reverting the gcc version back togcc-7
until we fix the root cause.We need to install
gcc-7
explicitly now as ubuntu version has been upgraded by the same commit from 18 to 20. While ubuntu18 came withgcc-7
as default, ubuntu20 comes withgcc-9
.Also, removing
apt-get install cmake
aspip3 install cmake
already exists. Once tensorrt supports ubuntu 20.04, we can drop the 18.04 image and remove the pip3 installation in favor of apt (as apt install on 20.04 provides a recent enough cmake).