Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[v1.x] onnx fix fullyconnected #19693

Merged
merged 2 commits into from
Dec 19, 2020
Merged

[v1.x] onnx fix fullyconnected #19693

merged 2 commits into from
Dec 19, 2020

Conversation

Zha0q1
Copy link
Contributor

@Zha0q1 Zha0q1 commented Dec 18, 2020

the previous implementation only supports 2-d. This pr extends support to higher dim

@Zha0q1 Zha0q1 requested a review from szha as a code owner December 18, 2020 01:41
@mxnet-bot
Copy link

Hey @Zha0q1 , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [centos-gpu, unix-gpu, edge, windows-cpu, centos-cpu, miscellaneous, website, windows-gpu, clang, sanity, unix-cpu]


Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@lanking520 lanking520 added the pr-awaiting-testing PR is reviewed and waiting CI build and test label Dec 18, 2020
@lanking520 lanking520 added pr-work-in-progress PR is still work in progress and removed pr-awaiting-testing PR is reviewed and waiting CI build and test labels Dec 18, 2020
@lanking520 lanking520 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress pr-awaiting-review PR is waiting for code review and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Dec 19, 2020
Copy link
Contributor

@josephevans josephevans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Zha0q1 Zha0q1 merged commit 403d31f into apache:v1.x Dec 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr-awaiting-review PR is waiting for code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants