-
Notifications
You must be signed in to change notification settings - Fork 6.8k
[1.x][submodule] Upgrade oneDNN to v2.0 #19670
Conversation
Hey @bartekkuncer , Thanks for submitting the PR
CI supported jobs: [centos-cpu, miscellaneous, windows-cpu, website, centos-gpu, sanity, clang, edge, unix-cpu, windows-gpu, unix-gpu] Note: |
ec9c876
to
8717650
Compare
8717650
to
d1272ec
Compare
@szha Please help with the merge. This change just upgrades oneDNN used by mxnet to v2.0 on branch 1.x. |
@mxnet-bot run ci [unix-gpu] |
Jenkins CI successfully triggered : [unix-gpu] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this will impact those who integrate with pip through the included header files.
@szha Is there a way I can help with that? |
d1272ec
to
4a01821
Compare
@mxnet-bot run ci [unix-gpu] |
Jenkins CI successfully triggered : [unix-gpu] |
@szha Hi, can this change be merged now? |
@szha Hi, can we upgrade oneDNN to v2.0 on 1.x? :) |
@bartekkuncer I think we can, provided that downstream users/developers don't have to make code changes to integrate with mxnet. This means everything should be consistent, including function signatures (and integrating with a compatibility layer is ok), header files and locations, dynamically loaded dependencies. |
@szha I believe the change keeps the file location consistency with previous state of the branch. |
This reverts commit 031dc5b.
I cannot see UNIX CPU and GPU for this PR. I get the following error:
|
This reverts commit 031dc5b.
This change upgrades oneDNN on branch 1.x to v2.0.