Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[1.x][submodule] Upgrade oneDNN to v2.0 #19670

Merged
merged 1 commit into from
Feb 8, 2021
Merged

Conversation

bartekkuncer
Copy link
Contributor

This change upgrades oneDNN on branch 1.x to v2.0.

@mxnet-bot
Copy link

Hey @bartekkuncer , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [centos-cpu, miscellaneous, windows-cpu, website, centos-gpu, sanity, clang, edge, unix-cpu, windows-gpu, unix-gpu]


Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@lanking520 lanking520 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-awaiting-testing PR is reviewed and waiting CI build and test labels Dec 14, 2020
@lanking520 lanking520 added pr-awaiting-testing PR is reviewed and waiting CI build and test and removed pr-work-in-progress PR is still work in progress labels Dec 15, 2020
@lanking520 lanking520 added pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test pr-awaiting-review PR is waiting for code review and removed pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress labels Dec 15, 2020
@bartekkuncer
Copy link
Contributor Author

@szha Please help with the merge. This change just upgrades oneDNN used by mxnet to v2.0 on branch 1.x.

@lanking520 lanking520 added pr-work-in-progress PR is still work in progress and removed pr-awaiting-review PR is waiting for code review labels Dec 15, 2020
@bartekkuncer
Copy link
Contributor Author

@mxnet-bot run ci [unix-gpu]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [unix-gpu]

@lanking520 lanking520 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-awaiting-review PR is waiting for code review and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Dec 15, 2020
Copy link
Member

@szha szha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this will impact those who integrate with pip through the included header files.

@bartekkuncer
Copy link
Contributor Author

bartekkuncer commented Dec 16, 2020

I think this will impact those who integrate with pip through the included header files.

@szha Is there a way I can help with that?

@lanking520 lanking520 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-awaiting-review PR is waiting for code review pr-awaiting-testing PR is reviewed and waiting CI build and test labels Jan 7, 2021
@bartekkuncer
Copy link
Contributor Author

@mxnet-bot run ci [unix-gpu]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [unix-gpu]

@lanking520 lanking520 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-awaiting-review PR is waiting for code review and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Jan 8, 2021
@bartekkuncer
Copy link
Contributor Author

@szha Hi, can this change be merged now?

@bartekkuncer
Copy link
Contributor Author

@szha Hi, can we upgrade oneDNN to v2.0 on 1.x? :)

@szha
Copy link
Member

szha commented Feb 1, 2021

@bartekkuncer I think we can, provided that downstream users/developers don't have to make code changes to integrate with mxnet. This means everything should be consistent, including function signatures (and integrating with a compatibility layer is ok), header files and locations, dynamically loaded dependencies.

@bartekkuncer
Copy link
Contributor Author

@bartekkuncer I think we can, provided that downstream users/developers don't have to make code changes to integrate with mxnet. This means everything should be consistent, including function signatures (and integrating with a compatibility layer is ok), header files and locations, dynamically loaded dependencies.

@szha I believe the change keeps the file location consistency with previous state of the branch.

@szha szha merged commit 031dc5b into apache:v1.x Feb 8, 2021
Zha0q1 added a commit to Zha0q1/incubator-mxnet that referenced this pull request Feb 8, 2021
@szha szha mentioned this pull request Feb 8, 2021
@access2rohit
Copy link
Contributor

I cannot see UNIX CPU and GPU for this PR. I get the following error:


URI: | /job/mxnet-validation/job/unix-cpu/job/PR-19670/4/display/redirect
-- | --
404
Not Found
Stapler

josephevans pushed a commit to josephevans/mxnet that referenced this pull request Feb 9, 2021
@bartekkuncer bartekkuncer deleted the onednn201x branch February 22, 2021 11:06
@bartekkuncer bartekkuncer mentioned this pull request Feb 22, 2021
13 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr-awaiting-review PR is waiting for code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants