Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[v1.x] Add 1:many conversions in nnvm_to_onnx and non-flatten GEMM #19652

Merged
merged 1 commit into from
Jan 5, 2021

Conversation

Kh4L
Copy link
Contributor

@Kh4L Kh4L commented Dec 9, 2020

Description

This PR:

  • refactors nnvm_to_onnx to enable one to many conversions. It allows single NNVM operators to be converted in a subgraph of several ONNX operators.
  • adds correct support of FullyConnected layers with flatten=False, which are not supported natively supported by ONNX and TensorRT. It converts the operator to a subgraph composed of Transpose+MatMul+Add ONNX ops.
  • adds conversions for Slice and SoftmaxOutput

@mxnet-bot
Copy link

Hey @Kh4L , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [centos-cpu, website, sanity, clang, unix-cpu, unix-gpu, windows-cpu, windows-gpu, edge, centos-gpu, miscellaneous]


Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@lanking520 lanking520 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-awaiting-review PR is waiting for code review and removed pr-awaiting-testing PR is reviewed and waiting CI build and test labels Dec 9, 2020
Copy link
Member

@ptrendx ptrendx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ptrendx ptrendx merged commit a9466cf into apache:v1.x Jan 5, 2021
Kh4L added a commit to Kh4L/incubator-mxnet that referenced this pull request Mar 5, 2021
@Kh4L Kh4L mentioned this pull request Mar 5, 2021
ptrendx pushed a commit that referenced this pull request Mar 5, 2021
* Update MXNet-TRT doc with the new optimize_for API

Signed-off-by: Serge Panev <[email protected]>

* [1.x] Move block.optimize_for backend_opts to kwargs (#19386)

* Move block.optimize_for backend_opts to kwargs

Signed-off-by: Serge Panev <[email protected]>

* Update Hybridize to use kwargs as backend opts

Signed-off-by: Serge Panev <[email protected]>

* Fix lint

Signed-off-by: Serge Panev <[email protected]>

* Change clear default to False and allow hybrize+optimize_for calls

Signed-off-by: Serge Panev <[email protected]>

* Fix nit

Signed-off-by: Serge Panev <[email protected]>

* Adress review comments

Signed-off-by: Serge Panev <[email protected]>

* Adress more review comments

Signed-off-by: Serge Panev <[email protected]>

* Adress more more review comments

Signed-off-by: Serge Panev <[email protected]>

* Fix nit

Signed-off-by: Serge Panev <[email protected]>

* Add 1:many conversions in nnvm_to_onnx and non-flatten GEMM (#19652)

Signed-off-by: Serge Panev <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr-awaiting-review PR is waiting for code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants