Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[v1.7.x] Backport CI fixes (#19377) #19389

Merged
merged 3 commits into from
Oct 21, 2020
Merged

[v1.7.x] Backport CI fixes (#19377) #19389

merged 3 commits into from
Oct 21, 2020

Conversation

josephevans
Copy link
Contributor

@josephevans josephevans commented Oct 20, 2020 •
edited by samskalicky
Loading

Backport #19377 to v1.7.x

  • Update repo and key used for installing r. Should fix sanity builds in v1.x.

  • Use correct repo (trusty) as v1.x branch uses ubuntu:16.04 for container. Also remove copy GPG key command.

  • Remove all references to old expired key.

Co-authored-by: Joe Evans [email protected]

Description

(Brief description on what this PR is about)

Checklist

Essentials

  • PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage
  • Code is well-documented

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@josephevans
Fix CI builds failing due to invalid GPG keys. (apache#19377)
d25dd9a 
* Update repo and key used for installing r. Should fix sanity builds in v1.x.

* Use correct repo (trusty) as v1.x branch uses ubuntu:16.04 for container. Also remove copy GPG key command.

* Remove all references to old expired key.

Co-authored-by: Joe Evans <[email protected]>
@mxnet-bot
Copy link

Hey @josephevans , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [miscellaneous, centos-cpu, sanity, edge, website, windows-cpu, unix-gpu, clang, windows-gpu, unix-cpu, centos-gpu]

Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@lanking520 lanking520 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress labels Oct 20, 2020
@lanking520 lanking520 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Oct 20, 2020
@lanking520 lanking520 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress pr-awaiting-review PR is waiting for code review and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Oct 20, 2020
@samskalicky samskalicky merged commit f028cf8 into apache:v1.7.x Oct 21, 2020
@josephevans josephevans deleted the ci_fixes_v1.7.x branch October 21, 2020 05:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@aaronmarkham aaronmarkham Awaiting requested review from aaronmarkham aaronmarkham is a code owner

@marcoabreu marcoabreu Awaiting requested review from marcoabreu marcoabreu is a code owner

Assignees
No one assigned
Labels
pr-awaiting-review PR is waiting for code review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@josephevans @mxnet-bot @samskalicky @lanking520