Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Skip flaky memory profiler tests #19346

Merged
merged 2 commits into from
Nov 5, 2020
Merged

Skip flaky memory profiler tests #19346

merged 2 commits into from
Nov 5, 2020

Conversation

leezu
Copy link
Contributor

@leezu leezu commented Oct 13, 2020 •
edited
Loading

Skip flaky tests as segfaulting tests may not be retried with flaky plugin.

See #18564

@mxnet-bot
Copy link

Hey @leezu , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [sanity, centos-cpu, windows-gpu, clang, edge, miscellaneous, windows-cpu, unix-gpu, unix-cpu, website, centos-gpu]

Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@leezu leezu changed the title Mark GPU memory profiler tests as flaky Skip flaky test_gpu_memory_profiler_symbolic Oct 13, 2020
@lanking520 lanking520 added the pr-work-in-progress PR is still work in progress label Oct 14, 2020
@leezu leezu closed this Nov 4, 2020
@leezu leezu reopened this Nov 5, 2020
@leezu leezu changed the title Skip flaky test_gpu_memory_profiler_symbolic Skip flaky memory profiler tests Nov 5, 2020
@lanking520 lanking520 added pr-awaiting-testing PR is reviewed and waiting CI build and test and removed pr-work-in-progress PR is still work in progress labels Nov 5, 2020
@leezu leezu requested a review from szha November 5, 2020 02:02
@lanking520 lanking520 added pr-work-in-progress PR is still work in progress pr-awaiting-review PR is waiting for code review and removed pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress labels Nov 5, 2020
@szha szha merged commit b409371 into master Nov 5, 2020
@szha szha deleted the leezu-patch-2 branch November 5, 2020 16:40
vidyaravipati pushed a commit to vidyaravipati/incubator-mxnet that referenced this pull request Nov 11, 2020
@leezu
Skip flaky memory profiler tests (apache#19346)
cb67387 
* Skip GPU memory profiler tests due to flaky segmentation faults

* Skip test_aggregate_duplication(
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@szha szha Awaiting requested review from szha

Assignees
No one assigned
Labels
pr-awaiting-review PR is waiting for code review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@leezu @mxnet-bot @szha @lanking520