Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Address Leo's comments on PR#18704 #19154

Merged
merged 1 commit into from
Sep 17, 2020
Merged

Address Leo's comments on PR#18704 #19154

merged 1 commit into from
Sep 17, 2020

Conversation

ArmageddonKnight
Copy link
Contributor

@ArmageddonKnight ArmageddonKnight commented Sep 15, 2020 •
edited
Loading

@leezu @szha FYI, I have addressed the comments on PR #18704 . Please let me know if there are any other issues or concerns. Thank you.

@mxnet-bot
Copy link

Hey @ArmageddonKnight , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [centos-gpu, sanity, edge, miscellaneous, windows-cpu, unix-gpu, clang, website, centos-cpu, windows-gpu, unix-cpu]

Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@ArmageddonKnight
Copy link
Contributor Author

ArmageddonKnight commented Sep 15, 2020 •
edited
Loading

@mxnet-bot run ci [centos-gpu]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [sanity]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [sanity, edge, windows-cpu, clang, unix-cpu, miscellaneous, centos-gpu, website, unix-gpu, centos-cpu, windows-gpu]

@leezu
Copy link
Contributor

leezu commented Sep 16, 2020

@mxnet-bot run ci [centos-gpu]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [centos-gpu]

@leezu
Copy link
Contributor

leezu commented Sep 16, 2020

@mxnet-bot run ci [centos-gpu]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [centos-gpu]

@ArmageddonKnight
Copy link
Contributor Author

@leezu FYI, it has passed all CI tests.

leezu
leezu reviewed Sep 16, 2020
View reviewed changes
tests/python/gpu/test_profiler_gpu.py Outdated Show resolved Hide resolved
tests/python/gpu/test_profiler_gpu.py Outdated Show resolved Hide resolved
@mxnet-bot
Copy link

Jenkins CI successfully triggered : [centos-gpu]

@ArmageddonKnight
Copy link
Contributor Author

@leezu FYI, all CI tests have passed.

@leezu leezu merged commit 25ab7a6 into apache:master Sep 17, 2020
@leezu
Copy link
Contributor

leezu commented Sep 17, 2020

Thank you @ArmageddonKnight !

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Zha0q1 Zha0q1 Zha0q1 left review comments

@leezu leezu leezu left review comments

@szha szha Awaiting requested review from szha szha is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ArmageddonKnight @mxnet-bot @leezu @Zha0q1