Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[BUGFIX] FindMKL.cmake fix comment and cmake variables and search paths #19152

Merged
merged 1 commit into from
Sep 15, 2020

Conversation

sfraczek
Copy link
Contributor

Description

Fixes to small bugs in FindMKL.cmake explained here: #19151

Checklist

Essentials

  • PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
  • Changes are complete (i.e. I finished coding on this PR)
  • Code is well-documented

Comments

Regarding backwards compatibility: If someone previously used MKL_ROOT environment variable set manually because MKLROOT wasn't working, then this change may break things for them if they don't have MKLROOT env var set (which is done by sourcing mklvars.sh by the book https://software.intel.com/content/www/us/en/develop/documentation/mkl-linux-developer-guide/top/getting-started/setting-environment-variables/scripts-to-set-environment-variables.html).

@mxnet-bot
Copy link

Hey @sfraczek , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [windows-cpu, unix-gpu, edge, sanity, windows-gpu, unix-cpu, centos-gpu, website, miscellaneous, clang, centos-cpu]


Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

Copy link
Contributor

@leezu leezu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. Renaming MKL_ROOT to MKLROOT for the env variable check is not backwards compatible, but common MKLROOT is common whereas MKL_ROOT isn't

@leezu leezu merged commit 11e1c0b into apache:master Sep 15, 2020
@sfraczek sfraczek deleted the findmkl-fix-vars branch September 16, 2020 06:35
@access2rohit access2rohit mentioned this pull request Feb 17, 2021
13 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants