-
Notifications
You must be signed in to change notification settings - Fork 6.8k
Fix (log_)softmax backward on empty ndarray #18711
Conversation
Hey @bgawrych , Thanks for submitting the PR
CI supported jobs: [unix-gpu, clang, unix-cpu, windows-gpu, centos-gpu, website, windows-cpu, miscellaneous, edge, centos-cpu, sanity] Note: |
Could you please add two unit-tests Thank you! |
@wkcn Please correct me if I'm wrong but doesn't empty array (e.g. [3,0,4]) is allowed only when numpy semantics is turned on and legacy mode doesn't support this? |
@bgawrych sorry for my mistake. We does not need to add test for legacy operator. |
@wkcn It's already done :) Function test_npx_softmax (tests/python/unittest/test_numpy_op.py:1916) is checking empty forward and backward pass |
@mxnet-bot run ci [centos-cpu] |
Jenkins CI successfully triggered : [centos-cpu] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you!
@mxnet-bot run ci [centos-cpu] |
Jenkins CI successfully triggered : [centos-cpu] |
I'm working on a PR that is mostly failing due to the issues this PR fixes, so I'll be happy to see this merged. Are the CI failures you're seeing related to this commit, thus requiring a follow-up commit, or are you done? I'm thinking about cherry-picking your present commit onto my PR so I can get to a cleaner CI. |
The errors seem unrelated. @mxnet-bot run ci [centos-cpu] |
Jenkins CI successfully triggered : [centos-cpu] |
My PR is having the same 'worker crash' problem this PR is having. Without understanding the root cause, I tried marking the failing test in unittest/test_sparse_operator.py as serial, and I got no similar failures. So you might give this a try:
|
Closing, as fix have been merged to master in #18694 |
Description
This pull request fixes #18710 issue. Fixed in the same way as forward pass
Checklist
Essentials