This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
Update nccl installation in Dockerfile.build.centos7 #18441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By moving the NCCL installation before the COPY runtime_functions.sh statement, users will not suffer from cache invalidation due to the COPY and don't have to repeat the nccl installation locally as there will be a cache hit.
|
Hey @leezu , Thanks for submitting the PR
CI supported jobs: [sanity, windows-gpu, unix-gpu, centos-cpu, miscellaneous, clang, website, edge, windows-cpu, centos-gpu, unix-cpu] Note: |
|
@mxnet-bot run ci [miscellaneous] |
|
Jenkins CI successfully triggered : [miscellaneous] |
ys2843
pushed a commit
to ys2843/incubator-mxnet
that referenced
this pull request
Jun 2, 2020
By moving the NCCL installation before the COPY runtime_functions.sh statement, users will not suffer from cache invalidation due to the COPY and don't have to repeat the nccl installation locally as there will be a cache hit.
yijunc
pushed a commit
to yijunc/incubator-mxnet
that referenced
this pull request
Jun 9, 2020
By moving the NCCL installation before the COPY runtime_functions.sh statement, users will not suffer from cache invalidation due to the COPY and don't have to repeat the nccl installation locally as there will be a cache hit.
AntiZpvoh
pushed a commit
to AntiZpvoh/incubator-mxnet
that referenced
this pull request
Jul 6, 2020
By moving the NCCL installation before the COPY runtime_functions.sh statement, users will not suffer from cache invalidation due to the COPY and don't have to repeat the nccl installation locally as there will be a cache hit.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By moving the NCCL installation before the
COPY runtime_functions.shstatement, users will notsuffer from cache invalidation due to the COPY and don't have to repeat the
nccl installation locally as there will be a cache hit when using
python ci/build.py --platform centos7_gpu_cu100 /work/runtime_functions.sh build_static_libmxnet cu100.