This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add image classification tutorial for jetson #18434
add image classification tutorial for jetson #18434
Changes from all commits
849d5f1
386d236
76675ee
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
http://www.apache.org/legal/release-policy.html#publication
It would be better to replace this with cross-compilation instructions based on the official ASF release (https://downloads.apache.org/incubator/mxnet/1.6.0/) to be compliant with ASF policy.
The wheel you download here is not ASF compliant (contains CUDA code) and must not be distributed by MXNet officially (and it's currently not distributed by MXNet [which is good] but by a third party; however that's not obvious to people reading the website).
Adding this link as an optional part of the tutorial and putting a big disclaimer that this is not an ASF release and provided at user's own risk by a third party could be fine. We should open a ticket with Apache Legal team to reconfirm.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mseth10 - How do we proceed further? @leezu - Can you help with ticket to Apache ? Any recommendation here apart from adding disclaimer.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @sandeep-krishnamurthy , as per an offline discussion with @leezu , there is an ongoing discussion with Apache on this issue: https://issues.apache.org/jira/browse/LEGAL-515
To move ahead with this tutorial, we have decided to update the jetson installation doc on MXNet website and referring to that as the primary method in the tutorial. As an alternative, we'll provide users with the option to download the wheel with the disclaimer that the wheel is not an ASF release.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have updated the tutorial accordingly and created a PR to update Jetson installation docs #18485 with the Make instructions. I'll add cmake cross-compilation steps to the doc in a later PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bertrand from the Incubator suggested the following disclaimer:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @leezu
@mseth10 - Let us get this warning note put in the tutorial, get review and approve from @leezu and move this forward please. thank you.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found at https://downloads.apache.org/incubator/mxnet/ ? @leezu
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made the changes. Can you please help merge @leezu