Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[numpy] fix mixed type binary logic operators #18427

Merged
merged 1 commit into from
Jun 2, 2020

Conversation

yijunc
Copy link
Contributor

@yijunc yijunc commented May 28, 2020

Description

Attempt to fix issue #18299

Now, logical binary ops' lhs and rhs will be cast to double before the op is performed.
@yzhliu

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@mxnet-bot
Copy link

Hey @BenjaminCHEN2016 , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [edge, centos-cpu, centos-gpu, website, clang, windows-gpu, sanity, unix-cpu, unix-gpu, windows-cpu, miscellaneous]


Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@yijunc yijunc force-pushed the fix_issue_18299 branch from 8f4120e to 8ef646d Compare May 28, 2020 09:50
@yijunc
Copy link
Contributor Author

yijunc commented May 28, 2020

@mxnet-bot run ci [miscellaneous]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [miscellaneous]

@yijunc
Copy link
Contributor Author

yijunc commented May 28, 2020

@mxnet-bot run ci [unix-cpu]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [unix-cpu]

@yijunc
Copy link
Contributor Author

yijunc commented May 28, 2020

@mxnet-bot run ci [miscellaneous]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [miscellaneous]

@yijunc
Copy link
Contributor Author

yijunc commented May 29, 2020

@mxnet-bot run ci [miscellaneous]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [miscellaneous]

@yijunc yijunc force-pushed the fix_issue_18299 branch from 8ef646d to 5ced172 Compare May 29, 2020 09:09
@yijunc yijunc changed the title [WIP][numpy] fix mixed type binary logic operators [numpy] fix mixed type binary logic operators May 29, 2020
@yijunc
Copy link
Contributor Author

yijunc commented Jun 1, 2020

@mxnet-bot run ci [miscellaneous, unix-cpu]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [unix-cpu, miscellaneous]

@yzhliu yzhliu linked an issue Jun 2, 2020 that may be closed by this pull request
@yzhliu yzhliu merged commit c59a325 into apache:master Jun 2, 2020
@yzhliu
Copy link
Member

yzhliu commented Jun 2, 2020

Thanks @BenjaminCHEN2016

ys2843 pushed a commit to ys2843/incubator-mxnet that referenced this pull request Jun 2, 2020
AntiZpvoh pushed a commit to AntiZpvoh/incubator-mxnet that referenced this pull request Jul 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fail to use "==" operation between different types
3 participants