change _Pragma to #pragma #18379
change _Pragma to #pragma #18379
Conversation
|
Hey @yajiedesign , Thanks for submitting the PR
CI supported jobs: [windows-gpu, edge, clang, miscellaneous, windows-cpu, centos-cpu, centos-gpu, unix-cpu, website, sanity, unix-gpu] Note: |
|
|
src/io/batchify.cc
Outdated
| @@ -150,7 +150,7 @@ class StackBatchify : public BatchifyFunction { | |||
| } | |||
| int sbs = static_cast<int>(bs); | |||
| MSHADOW_TYPE_SWITCH_WITH_BOOL(dtype, DType, { | |||
| _Pragma("omp parallel for num_threads(bs)") | |||
| #pragma omp parallel for num_threads(bs) | |||
There was a problem hiding this comment.
use __pragma for msvc if it does not support _Pragma
There was a problem hiding this comment.
We can unify the macro like
#ifndef _MSC_VER
#define __pragma(id) _Pragma(#id)
#endif
|
I'll try upgrading vs |
|
Cannot be resolved by upgrade vs. |
|
@mxnet-bot run ci [windows-cpu] |
|
Jenkins CI successfully triggered : [windows-cpu] |
src/io/batchify.cc
Outdated
|
|
||
| #ifdef _MSC_VER | ||
| #if _MSC_VER < 1925 | ||
| #define omp_parallel __pragma(omp parallel for num_threads(bs)) |
There was a problem hiding this comment.
Can you make bs argument of the macro?
There was a problem hiding this comment.
Could you clarify why CI test using MSVC 2019 work well but you run into issues on the CD? I think the MSVC 2019 version is the minimum supported version for MXNet 2, so the correct step may be to update the MSVC for CD?
As long as we test MSVC 2019 on CI, any new commit may break the CD again as long as you use an older MSVC on the CD?
|
@leezu Because CUDA. The old version of CUDA does not support the new version of msvc. |
|
Thanks for clarifying. In that case, should we either drop the old Cuda versions for MXNet 2 or switch the CI to an older MSVC version? What do you think? |
|
(Soon Cuda 11 will be released and we'll drop Cuda 9 support in any case) |
|
Keep the MSVC of CI compatible with the minimum supported CUDA version. |
|
Yes, that's an option. I'm not convinced though that only fixing this current incompatibility without introducing any mechanism of preventing future problems is helpful. |
|
@mxnet-bot run ci [macosx-x86_64] |
|
None of the jobs entered are supported. |
|
@yajiedesign please clarify how you plan to address the CI CD discrepancy? |
* change _Pragma to #pragma._Pragma not work with msvc * new plan * fix lint * add arg * fix * fix lint * fix
Description
change _Pragma to #pragma
_Pragma not work with msvc
Checklist
Essentials
Changes
Comments