Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Fix reference leak in Block._children and enable reference leak tests universally #18376

Merged
merged 4 commits into from
May 22, 2020

Conversation

leezu
Copy link
Contributor

@leezu leezu commented May 20, 2020

Description

Fix reference leak in Block._children and enable reference leak tests universally.
Extends #18328 #18363

@mxnet-bot
Copy link

Hey @leezu , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [miscellaneous, clang, unix-cpu, edge, windows-cpu, windows-gpu, unix-gpu, website, sanity, centos-cpu, centos-gpu]


Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@leezu leezu force-pushed the testmemoryleaks branch 2 times, most recently from 1fd429a to c543830 Compare May 21, 2020 05:29
pytest.ini Outdated Show resolved Hide resolved
@leezu leezu marked this pull request as ready for review May 21, 2020 23:39
@leezu leezu requested a review from szha May 22, 2020 18:04
@leezu leezu added the pr-awaiting-review PR is waiting for code review label May 22, 2020
@szha szha merged commit c3aff73 into apache:master May 22, 2020
@leezu leezu deleted the testmemoryleaks branch May 22, 2020 19:28
@leezu leezu mentioned this pull request May 29, 2020
AntiZpvoh pushed a commit to AntiZpvoh/incubator-mxnet that referenced this pull request Jul 6, 2020
… universally (apache#18376)

* Fix reference leak in Block._children

* Activate everywhere

* Disable on CentOS

* Fix
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr-awaiting-review PR is waiting for code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants