This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
cmake: check compiler supports C++17 sufficiently #18354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default cmake accepts any compiler that supports at least some part of C++17. In practice this leads to hard to understand error messages at later stages during compilation, as for example gcc5 supports part of C++17 but does not support C++17 sufficiently to compile MXNet.
|
Hey @leezu , Thanks for submitting the PR
CI supported jobs: [windows-cpu, clang, windows-gpu, miscellaneous, unix-gpu, centos-gpu, edge, unix-cpu, website, centos-cpu, sanity] Note: |
|
@mxnet-bot run ci [unix-gpu, miscellaneous] |
|
Jenkins CI successfully triggered : [unix-gpu, miscellaneous] |
AntiZpvoh
pushed a commit
to AntiZpvoh/incubator-mxnet
that referenced
this pull request
Jul 6, 2020
By default cmake accepts any compiler that supports at least some part of C++17. In practice this leads to hard to understand error messages at later stages during compilation, as for example gcc5 supports part of C++17 but does not support C++17 sufficiently to compile MXNet.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default cmake accepts any compiler that supports at least some part of C++17.
In practice this leads to hard to understand error messages at later stages
during compilation, as for example gcc5 supports part of C++17 but does not
support C++17 sufficiently to compile MXNet.
cc @apeforest