-
Notifications
You must be signed in to change notification settings - Fork 6.8k
[Website 2.0] Artifact URL Adjustment #18340
[Website 2.0] Artifact URL Adjustment #18340
Conversation
Hey @connorgoggins , Thanks for submitting the PR
CI supported jobs: [windows-cpu, unix-gpu, sanity, centos-cpu, centos-gpu, unix-cpu, website, windows-gpu, clang, miscellaneous, edge] Note: |
@mxnet-label-bot add [pr-awaiting-review] |
@mxnet-label-bot add [Website] |
@@ -20,7 +20,7 @@ all: html | |||
html: | |||
mkdir -p build | |||
cd src && bundle install && JEKYLL_ENV=production bundle exec jekyll build --config _config_prod.yml -d ../build/html && cd .. | |||
wget https://mxnet-static-artifacts.s3.amazonaws.com/versions.zip && unzip versions.zip -d build/html && rm -rf build/html/__MACOSX && rm versions.zip | |||
wget https://mxnet-website-static-artifacts.s3.us-east-2.amazonaws.com/versions.zip && unzip versions.zip -d build/html && rm -rf build/html/__MACOSX && rm versions.zip |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the macosx folder for?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When ZIP artifacts are compiled on a Mac (as the current artifact is), the __MACOSX
folder is autogenerated when they are extracted. If future versions of the artifact are compiled using a different OS, this won't cause any problems since the rm -rf
command will pass even if the specified folder doesn't exist.
* Testing new S3 bucket without publish step * Adding publish step & restricted nodes for prod * Drop restricted on primary node for testing' * Revert to restricted nodes with publishing
Description
This PR moves static artifacts to MXNet website artifacts public bucket.
Checklist
Essentials
Changes
Comments
These changes have been tested with a complete website build on Jenkins dev and local hosting. All functionality remains the same.
@sandeep-krishnamurthy @aaronmarkham @ys2843