Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[Numpy] FFI: max/min/amax/amin #17824

Merged
merged 4 commits into from
May 19, 2020
Merged

[Numpy] FFI: max/min/amax/amin #17824

merged 4 commits into from
May 19, 2020

Conversation

Tommliu
Copy link
Contributor

@Tommliu Tommliu commented Mar 13, 2020 •
edited
Loading

Description

New FFI imperative invocation for max, min ,amax, amin

Numpy Operator Old FFI (ctypes) (us) New FFI (cython) (us)
amax 26.98 7.94
amin 26.9 7.84
max 27.51 7.87
min 27.02 7.92

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@Tommliu Tommliu requested a review from szha as a code owner March 13, 2020 07:36
hzfan
hzfan approved these changes Mar 13, 2020
View reviewed changes
Copy link
Contributor

@hzfan hzfan left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please fix the ci.

@haojin2 haojin2 added the Numpy label Mar 13, 2020
@Tommliu Tommliu force-pushed the ffi_max branch 3 times, most recently from 1aa6e73 to f63b13d Compare March 18, 2020 07:45
@Tommliu
Copy link
Contributor Author

Tommliu commented Mar 25, 2020

@mxnet-bot run ci [unix-gpu, windows-gpu]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [windows-gpu, unix-gpu]

@Tommliu
Copy link
Contributor Author

Tommliu commented Mar 25, 2020

@mxnet-bot run ci [windows-gpu]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [windows-gpu]

@Tommliu
Copy link
Contributor Author

Tommliu commented Mar 25, 2020

@mxnet-bot run ci [windows-gpu]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [windows-gpu]

@Tommliu
Copy link
Contributor Author

Tommliu commented Mar 26, 2020

@mxnet-bot run ci [windows-gpu]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [windows-gpu]

@Tommliu
Copy link
Contributor Author

Tommliu commented Apr 7, 2020

@mxnet-bot run ci [windows-gpu]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [windows-gpu]

@haojin2
Copy link
Contributor

haojin2 commented Apr 17, 2020

@mxnet-bot run ci [unix-gpu]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [unix-gpu]

@haojin2
Copy link
Contributor

haojin2 commented Apr 17, 2020

@mxnet-bot run ci [unix-gpu]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [unix-gpu]

@haojin2
Copy link
Contributor

haojin2 commented Apr 17, 2020

@mxnet-bot run ci [unix-gpu]

1 similar comment
@Tommliu
Copy link
Contributor Author

Tommliu commented Apr 20, 2020

@mxnet-bot run ci [unix-gpu]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [unix-gpu]

@Tommliu
Copy link
Contributor Author

Tommliu commented Apr 30, 2020

@mxnet-bot run ci [unix-gpu, unix-cpu, centos-cpu, website, windows-cpu, sanity]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [website, centos-cpu, unix-gpu, windows-cpu, sanity, unix-cpu]

@Tommliu
Copy link
Contributor Author

Tommliu commented Apr 30, 2020

@haojin2 last FFI Pr to be merged

@Tommliu
Copy link
Contributor Author

Tommliu commented May 7, 2020

@haojin2

@yzhliu yzhliu merged commit 53b34cb into apache:master May 19, 2020
AntiZpvoh pushed a commit to AntiZpvoh/incubator-mxnet that referenced this pull request Jul 6, 2020
@Tommliu @haojin2 @AntiZpvoh
[Numpy] FFI: max/min/amax/amin (apache#17824)
ff0fddf 
* ffi_min_max

* pylint fix

Co-authored-by: Hao Jin <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@haojin2 haojin2 haojin2 left review comments

@hzfan hzfan hzfan approved these changes

@yzhliu yzhliu yzhliu approved these changes

@szha szha Awaiting requested review from szha szha is a code owner

Assignees
No one assigned
Labels
Numpy
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Tommliu @mxnet-bot @haojin2 @yzhliu @hzfan