Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

skipping randint flaky test for large vector and reordering op execution #17388

Merged
merged 1 commit into from
Jan 21, 2020

Conversation

access2rohit
Copy link
Contributor

Description

Disables flaky test randint since natively none of the randing APIs used internally supports int64 the behavious is mostly flaky.

Reordering Op execution in group neural network operators(nn) to ensure ops don't fail due to execution order.

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Testing

MXNET_TEST_COUNT=1 nosetests --logging-level=DEBUG --verbose -s tests/nightly/test_large_vector.py:test_nn; 

/home/ubuntu/anaconda3/lib/python3.6/site-packages/h5py/__init__.py:36: FutureWarning: Conversion of the second argument of issubdtype from `float` to `np.floating` is deprecated. In future, it will be treated as `np.float64 == np.dtype(float).type`.
  from ._conv import register_converters as _register_converters
test_large_vector.test_nn ... [00:44:40] src/executor/graph_executor.cc:1982: Subgraph backend MKLDNN is activated.
[00:50:21] src/executor/graph_executor.cc:1982: Subgraph backend MKLDNN is activated.
ok

----------------------------------------------------------------------
Ran 1 test in 735.600s

OK

MXNET_TEST_COUNT=1 nosetests --logging-level=DEBUG --verbose -s tests/nightly/test_large_vector.py:test_tensor

/home/ubuntu/anaconda3/lib/python3.6/site-packages/h5py/__init__.py:36: FutureWarning: Conversion of the second argument of issubdtype from `float` to `np.floating` is deprecated. In future, it will be treated as `np.float64 == np.dtype(float).type`.
  from ._conv import register_converters as _register_converters
test_large_vector.test_tensor ... [DEBUG] Setting test np/mx/python random seeds, use MXNET_TEST_SEED=669456359 to reproduce.
SKIP: Randint flaky, tracked at https://github.com/apache/incubator-mxnet/issues/16172

----------------------------------------------------------------------
Ran 1 test in 107.868s

OK (SKIP=1)

MXNET_TEST_COUNT=1 nosetests --logging-level=DEBUG --verbose -s tests/nightly/test_large_vector.py:test_basic

/home/ubuntu/anaconda3/lib/python3.6/site-packages/h5py/__init__.py:36: FutureWarning: Conversion of the second argument of issubdtype from `float` to `np.floating` is deprecated. In future, it will be treated as `np.float64 == np.dtype(float).type`.
  from ._conv import register_converters as _register_converters
test_large_vector.test_basic ... ok

----------------------------------------------------------------------
Ran 1 test in 2086.958s

OK

@access2rohit
Copy link
Contributor Author

access2rohit commented Jan 21, 2020

@mxnet-label-bot add [pr-awaiting-review]

@lanking520 lanking520 added the pr-awaiting-review PR is waiting for code review label Jan 21, 2020
@access2rohit
Copy link
Contributor Author

@ChaiBapchya @apeforest PR ready for review

@apeforest
Copy link
Contributor

LGTM. @access2rohit Please create an issue for the out-of-memory when reordering ops. Thanks.

@apeforest apeforest merged commit 557a29b into apache:master Jan 21, 2020
szhengac pushed a commit to szhengac/mxnet that referenced this pull request Jan 21, 2020
szhengac pushed a commit to szhengac/mxnet that referenced this pull request Jan 21, 2020
szhengac pushed a commit to szhengac/mxnet that referenced this pull request Jan 21, 2020
szhengac pushed a commit to szhengac/mxnet that referenced this pull request Jan 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr-awaiting-review PR is waiting for code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants