Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Support R-package with cmake build and fix installation instructions #17228

Merged
merged 9 commits into from
Jan 14, 2020
Merged

Support R-package with cmake build and fix installation instructions #17228

merged 9 commits into from
Jan 14, 2020

Conversation

leezu
Copy link
Contributor

@leezu leezu commented Jan 6, 2020 •
edited
Loading

Description

Support R-package with cmake build and fix installation instructions

Also: Fixes #17103

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Support building R-package with cmake built libmxnet.so
  • Fix R-package installation instructions

@leezu leezu mentioned this pull request Jan 6, 2020
Closed
@szha
Copy link
Member

szha commented Jan 7, 2020

@hetong007 could you help verify this?

@leezu leezu requested a review from hetong007 January 7, 2020 14:36
This was referenced Jan 9, 2020
Open
Open
Open
@leezu
Copy link
Contributor Author

leezu commented Jan 13, 2020

I added a few more fixes to this PR. The current R-package was broken since #7273 #7389 due to missing linker arguments to the OpenCV dependency. It worked only due to some lucky circumstances such as order of dependency declaration in libmxnet.so that do not hold for CMake compiled version.

In particular, I updated the Makevars to fix the issue.

@leezu leezu merged commit 9f2e73f into apache:master Jan 14, 2020
@leezu leezu deleted the improverpkgbuild branch January 14, 2020 18:18
@leezu leezu mentioned this pull request Jan 16, 2020
Closed
ChaiBapchya added a commit to ChaiBapchya/mxnet that referenced this pull request Apr 7, 2020
@ChaiBapchya
fix R error; backport 1 line from apache#17228
2a77f2d
leezu pushed a commit that referenced this pull request Apr 10, 2020
@ChaiBapchya @xinyu-intel
[R][v1.6.x] Fix blocked pipelines [windows,unix-cpu,unix-gpu] on v1.6…
3ba1751 
….x (#17993)

* fix R error; backport 1 line from #17228

* print exception

* remove namespace to resolve load_module not found error

* fix static build ubuntu 1404 python error in nvidia docker gnutls handshake error

* fix rvm version error

* fix requantize flaky test (#16709)

Co-authored-by: Xinyu Chen <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hetong007 hetong007 hetong007 approved these changes

@aaronmarkham aaronmarkham Awaiting requested review from aaronmarkham aaronmarkham is a code owner

@marcoabreu marcoabreu Awaiting requested review from marcoabreu marcoabreu is a code owner

@szha szha Awaiting requested review from szha szha is a code owner

Assignees
No one assigned
Labels
Doc Installation R
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

R installation instructions out of date
3 participants
@leezu @szha @hetong007