-
Notifications
You must be signed in to change notification settings - Fork 6.8k
Adding user guidelines for using MXNet built with Large Tensor Support #16894
Conversation
|
||
Not supported: | ||
|
||
* GPU and MKLDNN. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Windows? Arm?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only Ubuntu. Will add that
* Other language bindings like Scala, Java, R, and Julia. | ||
|
||
## Performance Regression: | ||
Roughly 40 operators have shown performance regression in our preliminary analysis: Large Tensor Performance (https://docs.google.com/spreadsheets/d/1GpdNquQb71Is5B-li99JDuiLeEZd-eSjHIIowzGrwxc/edit#gid=1325641791) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since a Google docs document is not necessarily persistent, can we maybe add a spoiler or something like that (does our mark-up support it?)
Alternatively, we could just add it as attachment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@marcoabreu I didn't understand your point about google docs not being persistent. Also, can you tell me how can I add this excel sheet as attachment to the codebase ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@access2rohit How about exporting it to csv, then converting it to md with this tool? http://www.convertcsv.com/csv-to-markdown.htm
Then you can add it to this file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The issue is it's a big csv (400+ lines) so converting this to csv -> md and then adding it to this file will bloat the file (and won't look good with 400 lines)
What would you suggest in that case?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The issue is it's a big csv (400+ lines) so converting this to csv -> md and then adding it to this file will bloat the file (and won't look good with 400 lines)
What would you suggest in that case?
I thought it was just a list of 40. I see now that it has several sheets too. I'd leave it in excel format. What if you just upload a .xls file? I'm not sure of the best alternative here. If the person that has the file in the google drive deletes their account, the file is gone forever, so I agree it probably shouldn't live there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aaronmarkham Done!
621971b
to
9273fa0
Compare
@mxnet-label-bot add [pr-awaiting-review] |
8581d07
to
ed4195b
Compare
@aaronmarkham PR is ready for review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Retriggered unix-cpu (failed for unrelated clojure related network issue (known))
Rest LGTM ;)
@mxnet-label-bot add [pr-awaiting-merge] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Doc that layouts brief guidelines regarding how to use MXNet build with Large Tensor Support
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.