This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
Added more tests for Large Indices #15960
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mxnet-label-bot add [pr-awaiting-review] |
access2rohit
force-pushed
the
new_ops_large_vector
branch
from
094dc21
to
589b0ae
Compare
access2rohit
changed the title
access2rohit
force-pushed
the
new_ops_large_vector
branch
7 times, most recently
from
aa9146d
to
0a05d15
Compare
apeforest
reviewed
Aug 29, 2019
apeforest
reviewed
Aug 29, 2019
src/operator/tensor/indexing_op.h
Outdated
| @@ -1208,9 +1208,9 @@ template<int req> | |||
| struct one_hot { | |||
| template<typename DType, typename IType> | |||
| MSHADOW_XINLINE static void Map(int i, DType* out, const IType* indices, | |||
added 3 commits
August 29, 2019 21:47
…ong with new C_Apis supporting 64bit indexing
access2rohit
force-pushed
the
new_ops_large_vector
branch
from
0a05d15
to
585e0ef
Compare
ChaiBapchya
reviewed
Aug 29, 2019
tests/nightly/test_large_vector.py
Outdated
| @@ -170,6 +170,225 @@ def test_topk(): | |||
| assert val.sum() == (LARGE_X - 1) | |||
|
|
|||
|
|
|||
| def test_shape(): | |||
| b = create_vector(size=LARGE_X) | |||
| mx.nd.waitall() | |||
There was a problem hiding this comment.
#15941 review for wait all
…ces in one_hot operator
access2rohit
force-pushed
the
new_ops_large_vector
branch
from
585e0ef
to
ca83e3e
Compare
|
@mxnet-label-bot add [pr-awaiting-merge] |
zixuanweeei
pushed a commit
to zixuanweeei/mxnet
that referenced
this pull request
Sep 2, 2019
* Adding tests to verify support for Large Tensors in additional Ops along with new C_Apis supporting 64bit indexing * removing skipped tests * removing tests not required for vector testing * Adding more tests for Large Indices and adding support for Large Indices in one_hot operator * Re-Trigger build
access2rohit
added a commit
to access2rohit/incubator-mxnet
that referenced
this pull request
Sep 25, 2019
* Adding tests to verify support for Large Tensors in additional Ops along with new C_Apis supporting 64bit indexing * removing skipped tests * removing tests not required for vector testing * Adding more tests for Large Indices and adding support for Large Indices in one_hot operator * Re-Trigger build
access2rohit
added a commit
to access2rohit/incubator-mxnet
that referenced
this pull request
Sep 25, 2019
* Adding tests to verify support for Large Tensors in additional Ops along with new C_Apis supporting 64bit indexing * removing skipped tests * removing tests not required for vector testing * Adding more tests for Large Indices and adding support for Large Indices in one_hot operator * Re-Trigger build
access2rohit
added a commit
to access2rohit/incubator-mxnet
that referenced
this pull request
Sep 25, 2019
* Adding tests to verify support for Large Tensors in additional Ops along with new C_Apis supporting 64bit indexing * removing skipped tests * removing tests not required for vector testing * Adding more tests for Large Indices and adding support for Large Indices in one_hot operator * Re-Trigger build
6 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added tests for remainder of Ops that are required to support DGL on MXNet. Changes to support Large Indices in one_hot and slice_axis operators.
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
Testing
~/incubator-mxnet (new_ops_large_vector) $ MXNET_TEST_COUNT=1 nosetests --logging-level=DEBUG --verbose -s tests/nightly/test_large_vector.py/home/ubuntu/anaconda3/lib/python3.6/site-packages/h5py/init.py:36: FutureWarning: Conversion of the second argument of issubdtype from
floattonp.floatingis deprecated. In future, it will be treated asnp.float64 == np .dtype(float).type.from ._conv import register_converters as _register_converters
test_large_vector.test_slice ... ok
test_large_vector.test_ndarray_zeros ... ok
test_large_vector.test_ndarray_ones ... ok
test_large_vector.test_ndarray_random_uniform ... [DEBUG] Setting test np/mx/python random seeds, use MXNET_TEST_SEED=1631832474 to reproduce.
ok
test_large_vector.test_ndarray_random_randint ... [DEBUG] Setting test np/mx/python random seeds, use MXNET_TEST_SEED=1887298151 to reproduce.
ok
test_large_vector.test_ndarray_empty ... ok
test_large_vector.test_elementwise ... ok
test_large_vector.test_reduce ... ok
test_large_vector.test_clip ... ok
test_large_vector.test_argmin ... ok
test_large_vector.test_take ... ok
test_large_vector.test_slice_assign ... ok
test_large_vector.test_expand_dims ... ok
test_large_vector.test_squeeze ... ok
test_large_vector.test_broadcast_div ... ok
test_large_vector.test_Dense ... ok
test_large_vector.test_argsort ... ok
test_large_vector.test_sort ... ok
test_large_vector.test_topk ... ok
test_large_vector.test_shape ... ok
test_large_vector.test_size ... ok
test_large_vector.test_copy ... ok
test_large_vector.test_copy_to ... ok
test_large_vector.test_zeros_like ... ok
test_large_vector.test_ones_like ... ok
test_large_vector.test_concat ... ok
test_large_vector.test_sum ... ok
test_large_vector.test_prod ... ok
test_large_vector.test_min ... ok
test_large_vector.test_max ... ok
test_large_vector.test_argmax ... ok
test_large_vector.test_iadd ... ok
test_large_vector.test_isub ... ok
test_large_vector.test_imul ... ok
test_large_vector.test_idiv ... ok
test_large_vector.test_imod ... ok
test_large_vector.test_eq ... ok
test_large_vector.test_neq ... ok
test_large_vector.test_lt ... ok
test_large_vector.test_lte ... ok
test_large_vector.test_gt ... ok
test_large_vector.test_gte ... ok
test_large_vector.test_slice_like ... ok
test_large_vector.test_slice_axis ... ok
test_large_vector.test_full ... ok
test_large_vector.test_one_hot ... ok
Ran 46 tests in 16078.103s
OK