-
Notifications
You must be signed in to change notification settings - Fork 6.8k
Improve diagnose.py, adding build features info and binary library path. #15499
Conversation
Thank you for the improvement! LGTM. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you : )
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it cause any issue if user use this script to diagnose old mxnet release before 1.5?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, missed the try exception block in your code. It looks fine to me now.
One minor comment: the ✖ etc. symbols were not recognized when I import the txt file into MS office or Google Doc. Can we replace these unicode symbols by simple ascii, like Y/N? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please make the output format compatible with MS office.
I think they are valid unicode symbols, what problem are you experiencing with MS Office? I think that is out of scope of this PR as it requires changes to the Python code that prints the feature, feel free to send a different PR for that. |
@apeforest I don't have any problems with Google docs or Office with those unicode characters. |
See title.
This is the script used to fill issues, so adding more info will help.
Refined output:
diagnose.txt