This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
prevent TRT_Logger to be destroyed before TRT engine #14898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mxnet-label-bot add [pr-awaiting-review] |
ptrendx
reviewed
May 20, 2019
| const std::string& onnx_model, | ||
| int32_t max_batch_size, | ||
| size_t max_workspace_size, | ||
| nvinfer1::ILogger::Severity verbosity, | ||
| bool debug_builder) { | ||
| GOOGLE_PROTOBUF_VERIFY_VERSION; | ||
|
|
||
| TRT_Logger trt_logger(verbosity); | ||
| auto trt_builder = InferObject(nvinfer1::createInferBuilder(trt_logger)); | ||
| TRT_Logger* trt_logger = new TRT_Logger(verbosity); |
|
@Caenorst Could you have a look at the review comments? |
|
@Caenorst Gentle ping... |
|
Sure I can use a unique_ptr, I will make the change |
|
@KellenSunderland for review |
|
@KellenSunderland , @ptrendx Could you please review this PR? Thanks! |
|
@ptrendx Can you merge this PR if it looks good ? |
KellenSunderland
pushed a commit
to KellenSunderland/incubator-mxnet
that referenced
this pull request
Aug 13, 2019
* prevent TRT_Logger to be destroyed before TRT engine * use unique_ptr for trt_logger/parser/engine/executor ownership * reduce line length for lint
TaoLv
pushed a commit
that referenced
this pull request
Aug 16, 2019
anirudhacharya
pushed a commit
to anirudhacharya/mxnet
that referenced
this pull request
Aug 20, 2019
* prevent TRT_Logger to be destroyed before TRT engine * use unique_ptr for trt_logger/parser/engine/executor ownership * reduce line length for lint
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
prevent TRT_Logger to be destroyed before TRT engine
Checklist
Essentials
Changes
Comments