This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
empty list cannot be cleared issue fixed. #14882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mxnet-label-bot add [pr-awaiting-review] |
szha
reviewed
May 6, 2019
vandanavk
reviewed
May 10, 2019
example/ctc/multiproc_data.py
Outdated
| @@ -141,4 +141,5 @@ def reset(self): | |||
| print("Queue size on reset: {}".format(qsize)) | |||
| for i, p in enumerate(self.proc): | |||
| p.join() | |||
| self.proc.clear() | |||
| if len(self.proc) > 0: | |||
There was a problem hiding this comment.
maybe a more Pythonic way would be if self.proc ?
There was a problem hiding this comment.
I was using python2.7. I faced issue at that time. So I fixed it.
|
@hsali Could you please address the review comments? Thanks! |
|
@hsali Gentle ping.... |
|
LGTM. |
|
@hsali Thanks for your contribution. Could you please address the review comments and Is this PR good to go for merge? |
szha
approved these changes
Jul 19, 2019
piyushghai
approved these changes
Aug 2, 2019
|
Can a committer merge this PR ? This is good to go! |
|
@mxnet-bot run ci [all] |
|
Jenkins CI successfully triggered : [website, windows-cpu, edge, clang, centos-gpu, windows-gpu, unix-cpu, unix-gpu, centos-cpu, sanity, miscellaneous] |
|
sorry that it took (quite) a while. thanks for the fix @hsali |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
checking list before resetting it.
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
Changes
Comments