Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

corrected a spelling #14247

Merged
merged 1 commit into from
Mar 6, 2019
Merged

corrected a spelling #14247

merged 1 commit into from
Mar 6, 2019

Conversation

pldeepesh
Copy link
Contributor

Description

(Brief description on what this PR is about)

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@pldeepesh pldeepesh requested a review from szha as a code owner February 25, 2019 06:14
Copy link
Member

@wkcn wkcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!
LGTM : )

Copy link
Contributor

@ChaiBapchya ChaiBapchya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution. Since the CI failed for unrelated error, can you retrigger the CI by pushing an empty commit
Using something like

git commit --allow-empty -m "Trigger notification"

@szha
Copy link
Member

szha commented Feb 26, 2019

windows CI is currently not working so we need to wait until it's resolved to trigger again.

@anirudhacharya
Copy link
Member

@mxnet-label-bot add [pr-awaiting-merge]

@marcoabreu marcoabreu added the pr-awaiting-merge Review and CI is complete. Ready to Merge label Feb 27, 2019
@szha
Copy link
Member

szha commented Feb 27, 2019

@pldeepesh would you mind doing a rebase?

git remote add upstream https://github.com/apache/incubator-mxnet
git pull upstream master --rebase
# resolve conflicts if any
git push --force

@vandanavk
Copy link
Contributor

@mxnet-label-bot update [pr-awaiting-testing]

@marcoabreu marcoabreu added pr-awaiting-testing PR is reviewed and waiting CI build and test and removed pr-awaiting-merge Review and CI is complete. Ready to Merge labels Mar 4, 2019
@wkcn wkcn merged commit 39412b3 into apache:master Mar 6, 2019
@wkcn
Copy link
Member

wkcn commented Mar 6, 2019

Merged. Thanks!

@pldeepesh Would you like to submit a new PR to add your name in https://github.com/apache/incubator-mxnet/blob/master/CONTRIBUTORS.md ?

vdantu pushed a commit to vdantu/incubator-mxnet that referenced this pull request Mar 31, 2019
nswamy pushed a commit that referenced this pull request Apr 5, 2019
haohuanw pushed a commit to haohuanw/incubator-mxnet that referenced this pull request Jun 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr-awaiting-testing PR is reviewed and waiting CI build and test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants