Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Add test to check that binded is not set when exception thrown #12167

Merged
merged 5 commits into from
Aug 17, 2018
Merged

Add test to check that binded is not set when exception thrown #12167

Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
811e777
add test to check binded is not when exception thrown
azai91 Aug 14, 2018
f090785
add error to assertion
azai91 Aug 14, 2018
ead7e8f
fix typo by adding asserts
azai91 Aug 15, 2018
cea8e14
retrigger
azai91 Aug 16, 2018
8abde71
Merge branch 'master' into test/bind
azai91 Aug 17, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions tests/python/unittest/test_module.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,18 @@ def test_module_dtype():
assert x.dtype == dtype


def test_module_bind():
sym = mx.sym.Variable('data')
sym = mx.sym.Activation(data=sym, act_type='relu', __layout__='TNC')

mod = mx.mod.Module(sym, ('data',), None, context=[mx.cpu(0), mx.cpu(1)])
assertRaises(TypeError, mod.bind, data_shapes=[('data', mx.nd.array([10,10]))])
mod.binded = False
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you intended assert mod.binded == False?


mod.bind(data_shapes=[('data', (10,10))])
mod.binded = True
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you intended assert mod.binded == True?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wow...thanks lol



@with_seed()
def test_module_input_grads():
a = mx.sym.Variable('a', __layout__='NC')
Expand Down