Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[MXNET-313] Python: Resolve some of the undefined names #10490

Merged
merged 1 commit into from
Apr 23, 2018
Merged

[MXNET-313] Python: Resolve some of the undefined names #10490

merged 1 commit into from
Apr 23, 2018

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented Apr 10, 2018

Description

(Brief description on what this PR is about)

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@cclauss cclauss requested a review from szha as a code owner April 10, 2018 22:56
@marcoabreu
Copy link
Contributor

Thanks a lot for fixing the examples!

Committers, I think we definitely need to require tests for all examples since we're constantly running into issues like this.

@cclauss
Copy link
Contributor Author

cclauss commented Apr 10, 2018

$ flake8 . --count --select=E901,E999,F821,F822,F823 --show-source --statistics

In Travis CI would be a nice step forward.

@@ -646,7 +647,7 @@ def get_constant(self, name, value=None):
assert isinstance(param, Constant), \
"Parameter '{}' already exists but it is not a constant.".format(
name)
if isinstance(value, nd.NDArray):
if isinstance(value, mx.nd.NDArray):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nd has been imported as ndarray so you could use ndarray.NDArray I think to remain consistent with how it's been done in this file

@ThomasDelteil
Copy link
Contributor

ThomasDelteil commented Apr 12, 2018

C: 28, 0: third party import "import numpy as np" should be placed before "import mxnet as mx" (wrong-import-order)
  • could you please create a JIRA ticket for your PR? Thanks!

@cclauss cclauss changed the title Python: Resolve some of the undefined names [MXNET-313] Python: Resolve some of the undefined names Apr 12, 2018
@piiswrong piiswrong merged commit dc3ea81 into apache:master Apr 23, 2018
@cclauss cclauss deleted the python-fix-missing-imports branch April 24, 2018 02:36
rahul003 pushed a commit to rahul003/mxnet that referenced this pull request Jun 4, 2018
zheng-da pushed a commit to zheng-da/incubator-mxnet that referenced this pull request Jun 28, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants