Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[MXNET-143] Change MXNet-Scala namespace #10284

Merged
merged 5 commits into from
Apr 6, 2018
Merged

Conversation

nswamy
Copy link
Member

@nswamy nswamy commented Mar 27, 2018

Description

Changing MXNet-Scala namespace per the vote on dev list
https://lists.apache.org/thread.html/f4aafd0e772b8ae5d3a27fe30a354a11da188ad2c8282bad336f3037@%3Cdev.mxnet.apache.org%3E

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Feature1, tests, (and when applicable, API doc)
  • Feature2, tests, (and when applicable, API doc)

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@nswamy nswamy requested review from szha and yzhliu as code owners March 27, 2018 22:14
@Roshrini
Copy link
Member

Thanks for making this change. LGTM

@yzhliu yzhliu merged commit 590ec3f into apache:master Apr 6, 2018
rahul003 pushed a commit to rahul003/mxnet that referenced this pull request Jun 4, 2018
* change MXNet-Scala namespace from ml.dmlc to org.apache

* add import File

* change ml.dmlc to org.apache

* rename inferexample->infer

* rename inferexample->infer
zheng-da pushed a commit to zheng-da/incubator-mxnet that referenced this pull request Jun 28, 2018
* change MXNet-Scala namespace from ml.dmlc to org.apache

* add import File

* change ml.dmlc to org.apache

* rename inferexample->infer

* rename inferexample->infer
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants