Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Cannot concatenate boolean numpy arrays #18213

Closed
leezu opened this issue May 1, 2020 · 3 comments
Closed

Cannot concatenate boolean numpy arrays #18213

leezu opened this issue May 1, 2020 · 3 comments
Labels
Bug Numpy v2.0 WIP

Comments

@leezu
Copy link
Contributor

leezu commented May 1, 2020

Description

mx.np.concatenate([mx.np.zeros((1,), dtype='bool')]) is broken.

Error Message

File "src/operator/numpy/./np_matrix_op-inl.h", line 1160
MXNetError: Unknown type enum 7

cc @yzhliu
@leezu
Copy link
Contributor Author

leezu commented May 1, 2020

Related #16650

@leezu leezu added the v2.0 label May 6, 2020
@Tommliu
Copy link
Contributor

Tommliu commented May 8, 2020

working on it

@yzhliu yzhliu added the WIP label May 9, 2020
Tommliu added a commit to Tommliu/incubator-mxnet that referenced this issue May 11, 2020
@Tommliu
add boolean support for concatenate (apache#18213)
4558a97
@Tommliu Tommliu mentioned this issue May 11, 2020
Merged
7 tasks
Tommliu added a commit to Tommliu/incubator-mxnet that referenced this issue May 19, 2020
@Tommliu
add boolean support for concatenate (apache#18213)
8bfde6a
Tommliu added a commit to Tommliu/incubator-mxnet that referenced this issue May 21, 2020
@Tommliu
add boolean support for concatenate (apache#18213)
ef8c4c0
yzhliu pushed a commit that referenced this issue May 22, 2020
@Tommliu @cassinixu
Fix binary scalar dtype and add bool support (#18277)
48dea6e 
* add boolean support for concatenate (#18213)

* fix binary scalar logic dtype (#16964)

* common_expr test remove

* binary scalar op support scalar dtype

Co-Authored-By: Wentao Xu <[email protected]>

* test_error_fix

Co-authored-by: Wentao Xu <[email protected]>
@yzhliu
Copy link
Member

yzhliu commented May 22, 2020

closed by #18277

@yzhliu yzhliu closed this as completed May 22, 2020
AntiZpvoh pushed a commit to AntiZpvoh/incubator-mxnet that referenced this issue Jul 6, 2020
@Tommliu @cassinixu @AntiZpvoh
Fix binary scalar dtype and add bool support (apache#18277)
450b057 
* add boolean support for concatenate (apache#18213)

* fix binary scalar logic dtype (apache#16964)

* common_expr test remove

* binary scalar op support scalar dtype

Co-Authored-By: Wentao Xu <[email protected]>

* test_error_fix

Co-authored-by: Wentao Xu <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Bug Numpy v2.0 WIP
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@yzhliu @leezu @Tommliu