Fix clang-tidy

apache · Feb 5, 2020 · 69b989f · 69b989f
1 parent 2090398
commit 69b989f
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/src/api/api_lang.cc b/src/api/api_lang.cc
@@ -53,7 +53,7 @@ MXNET_REGISTER_GLOBAL("_Array")
       if (args[i].type_code() != kNull) {
         data.push_back(args[i].operator ObjectRef());
       } else {
-        data.push_back(ObjectRef(nullptr));
+        data.emplace_back(nullptr);
       }
     }
     auto node = make_object<ArrayNode>();

diff --git a/src/api/api_npi.cc b/src/api/api_npi.cc
@@ -130,7 +130,8 @@ MXNET_REGISTER_API("_npi.tensordot")
   if (isscalar) {
     mxnet::op::TensordotIntAxesParam param;
     param.axes = args[2].operator int();
-    attrs.parsed = std::move(param);
+    // we directly copy TensordotIntAxesParam, which is trivially-copyable
+    attrs.parsed = param;
   } else {
     mxnet::op::TensordotParam param;
     const runtime::ObjectRef ref = args[2].operator runtime::ObjectRef();