GH-461: Fix heartbeats with wantReply=true #507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gnodet
requested changes
May 28, 2024
sshd-core/src/main/java/org/apache/sshd/client/session/ClientConnectionService.java
Outdated
Show resolved
Hide resolved
sshd-core/src/main/java/org/apache/sshd/client/session/ClientConnectionService.java
Outdated
Show resolved
Hide resolved
sshd-core/src/main/java/org/apache/sshd/client/session/ClientConnectionService.java
Outdated
Show resolved
Hide resolved
sshd-core/src/main/java/org/apache/sshd/client/session/ClientConnectionService.java
Outdated
Show resolved
Hide resolved
gnodet
requested changes
May 28, 2024
sshd-core/src/main/java/org/apache/sshd/client/session/ClientConnectionService.java
Outdated
Show resolved
Hide resolved
Switch from a timeout model to the OpenSSH model: fail if there are more than a certain number of heartbeats for which no reply was received yet. Bug: apache#461
|
Also in the newest change: when TIMEOUT is explicitly set <= 0 and NO_REPLY_MAX is not set, set NO_REPLY_MAX to zero. |
gnodet
approved these changes
May 29, 2024
|
Thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch from a timeout model to the OpenSSH model: fail if there are more than a certain number of heartbeats for which no reply was received yet.
Fixes #461.