-
Notifications
You must be signed in to change notification settings - Fork 359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix mina full class name in BuiltinIoServiceFactoryFactories #510
Comments
Looks like an obvious bug. Probably this was missed in some earlier refactoring. Want to provide a PR? |
OK |
tomaswolf
pushed a commit
to JinHeap/mina-sshd
that referenced
this issue
May 30, 2024
The class name for the MinaServiceFactoryFactory was not updated in the refactoring in commit 5cbae28. Add a test that catches such mistakes, and exclude another test from being run with the MinaServiceFactoryFactory because it cannot work with a mocked ExecutorService. Bug: apache#510
tomaswolf
pushed a commit
to JinHeap/mina-sshd
that referenced
this issue
May 31, 2024
The class name for the MinaServiceFactoryFactory was not updated in the refactoring in commit 5cbae28. Add a test that catches such mistakes, and exclude another test from being run with the MinaServiceFactoryFactory because it cannot work with a mocked ExecutorService. Bug: apache#510
PR was merged as commit 82e0ed1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
mina-sshd/sshd-core/src/main/java/org/apache/sshd/common/io/BuiltinIoServiceFactoryFactories.java
Line 37 in 37d239e
full class name in BuiltinIoServiceFactoryFactories for mina is unavailable. I have to modified the code from org.apache.sshd.common.io.mina.MinaServiceFactoryFactory to org.apache.sshd.mina.MinaServiceFactoryFactory in order to run SshClientMain with mina
The text was updated successfully, but these errors were encountered: