Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MNG-8141] Do not loose model builder warnings #1567

Closed
wants to merge 2 commits into from

Conversation

cstamas
Copy link
Member

@cstamas cstamas commented Jun 7, 2024

Original change was merged but then reverted.

Changes in two areas:

  • if model builder detects any "issue" with model being built (again, there may be NO validation at all, as for dependencies models are being built with MIN validation, basically NOTHING is validated). The change is essentially limited to Profiles, as "problems" were already collected by ModelBuilder
  • artifact descriptor reader should not ignore WARNs as now, but report them. Before, ArtifactDescriptorReader was really tossing away WARNings from ModelBuilder, it reported them ONLY if Severity was FATAL or ERROR (as then ModelBuilder throws).

The goal is solely to make users aware, that their build pulls in dependencies (and dependencies of dependencies...) that have invalid POMs. This may affect build outcome, as for example inability to activate proper profile (ie. due duplicate profile IDs that IS caught by validation, but again, in this case deps-of-deps... we use MIN validation) may result in wrong dependendency set, missing properties and so on, as profile that was about to add these could not be activated.


https://issues.apache.org/jira/browse/MNG-8141

@cstamas cstamas requested a review from gnodet June 7, 2024 13:27
@cstamas cstamas self-assigned this Jun 7, 2024
@cstamas cstamas marked this pull request as ready for review June 7, 2024 13:47
That way is clear which artifact POM are wrong.
@cstamas cstamas changed the title [MNG-8141] Another attempt [MNG-8141] Do not loose model builder warnings Jun 7, 2024
@cstamas
Copy link
Member Author

cstamas commented Jun 7, 2024

The reproducer now looks like this https://gist.github.com/cstamas/36903dd7701cbae94d5971211e835b05
In DEBUG is like this https://gist.github.com/cstamas/4ad6bbb6b7f3350dbf5439e397131803

And is good, goal is to raise awareness to a presence of invalid model in the build. Build still fails due MNG-8147

@cstamas
Copy link
Member Author

cstamas commented Jun 7, 2024

Superseded by #1568

@cstamas cstamas closed this Jun 7, 2024
@cstamas cstamas deleted the maven-3.9.x-MNG-8141 branch June 7, 2024 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant