Hack for reactor reduction #1406
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gnodet
reviewed
Feb 8, 2024
| @@ -182,6 +183,18 @@ public class MavenProject implements Cloneable { | |||
|
|
|||
| private final Set<String> lifecyclePhases = Collections.synchronizedSet(new LinkedHashSet<>()); | |||
|
|
|||
| private final AtomicBoolean projectNeedsBuild = new AtomicBoolean(true); | |||
There was a problem hiding this comment.
this should only be set at the beginning, why using an AtomicBoolean ?
There was a problem hiding this comment.
I wanted just to ensure that "transition" from true->false can happen only once, and there is no way to "reset" it
There was a problem hiding this comment.
Again, this is just a hack to prove my theory, this flag is omitted from clone etc...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just a hack, to test my theory. And it makes issue of the reproducer gone, it is working "as expected" and is not broken.
https://lists.apache.org/thread/sgcqyz5trxngxb7r64hjnccb8btxhbrl
This PR makes the reproducer "work as expected", but is a hack. It produces output as this:
https://gist.github.com/cstamas/ac44420f45b8f3e0a4d1ff285ff7bbde
So, module-a is reported as "built", despite being skipped. But the build time of 0.017s is telling 😄 that really nothing happened, but just skipped. Again: this is a hack, not a fix.
full output of the build when using this PR
https://gist.github.com/cstamas/81eaba944d6ffe695c6ed2a35a8b6d7f