Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MNG-7670] Update misc dependencies #1089

Merged
merged 1 commit into from
Apr 17, 2023

Conversation

cstamas
Copy link
Member

@cstamas cstamas commented Apr 13, 2023

And do align them. Max Level is Java 8, but
we had several conflicts, like HttpClient
(used by Wagon but also by Resolver-Transport-Http).


https://issues.apache.org/jira/browse/MNG-7670

And do align them. Max Level is Java 8, but
we had several conflicts, like HttpClient
(used by Wagon but also by Resolver-Transport-Http).

---

https://issues.apache.org/jira/browse/MNG-7670
@cstamas cstamas self-assigned this Apr 13, 2023
@cstamas
Copy link
Member Author

cstamas commented Apr 13, 2023

@michael-o on JIRA you mention "Commons CLI must not be touched because the upgrade requires also code changes. See master.". What code changes you mean here?

I found this 4476026 but here parser is changed. Is it necessary? GnuParser is already deprecated (was in 1.3), but imho does not require code change, or I miss somethin?

@michael-o michael-o self-requested a review April 13, 2023 20:21
@michael-o
Copy link
Member

@michael-o on JIRA you mention "Commons CLI must not be touched because the upgrade requires also code changes. See master.". What code changes you mean here?

I found this 4476026 but here parser is changed. Is it necessary? GnuParser is already deprecated (was in 1.3), but imho does not require code change, or I miss somethin?

The migration introduces a slight incompat problem. That is why we did not touch it in 3.x. The previous impl was ugly, now I'd say that it is correct.

@cstamas cstamas marked this pull request as ready for review April 17, 2023 12:25
@cstamas
Copy link
Member Author

cstamas commented Apr 17, 2023

@michael-o so this PR is okay?

@michael-o
Copy link
Member

@michael-o so this PR is okay?

Yes, this is OK, if all ITs pass and if it is a sole CLI update w/o back porting the code from master. Honestly, I would back port the code from master with a separate issue.

@cstamas
Copy link
Member Author

cstamas commented Apr 17, 2023

@michael-o so you approve it?

@cstamas cstamas merged commit 924dbfe into apache:maven-3.9.x Apr 17, 2023
@cstamas cstamas deleted the maven-3.9.x-MNG-7670-deps branch April 17, 2023 13:23
@gnodet gnodet mentioned this pull request May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants