[SUREFIRE-1909] - Support JUnit 5 reflection access by changing add-exports to add-opens #471
Conversation
| public class AppTest | ||
| { | ||
| @Test | ||
| void testNoop() |
There was a problem hiding this comment.
This is the point of the test : to run package private test methods as suggested in JUnit 5 user guide
| { | ||
| public static void main( String... args ) | ||
| { | ||
| System.out.println( "module path => " + System.getProperty( "jdk.module.path" ) ); |
There was a problem hiding this comment.
@NilsRenaud
So, these lines are used as a debug info?
You can maybe utilize it and verify the classpath in one line, and modulapath in the second line via combining Java Hamcrest matchers.
Example:
validator.assertThatLogLine( containsString( "Running jiras.surefire1082.Jira1082Test" ), is( 1 ) );
Example with matching one line: allOf( containsString( "jar1" ), containsString( "jar2" ), ... )
The second argument is(1) only means the number of lines matching this criteria and it is 1 in this IT.
There was a problem hiding this comment.
I shamelessly copied an existing test with this content.
They are not useful because the java arg file content is displayed anyway. And I'm not really sure what I should verify with these paths.
So I rather like to delete these debug lines. WDYT ?
There was a problem hiding this comment.
After you have deleted it, we can force the build to run.
NilsRenaud
force-pushed
the
SUREFIRE-1909_replace_add_exports_with_add_opens
branch
from
9c12746
to
0f77b8a
Compare
| <plugin> | ||
| <groupId>org.apache.maven.plugins</groupId> | ||
| <artifactId>maven-compiler-plugin</artifactId> | ||
| <version>3.8.1</version> |
There was a problem hiding this comment.
It's better to use the latest version because we fixed some bugs and it would be nice to come over those in Surefire too.
…ts to add-opens Signed-off-by: Nils Renaud <[email protected]>
NilsRenaud
force-pushed
the
SUREFIRE-1909_replace_add_exports_with_add_opens
branch
from
0f77b8a
to
c632a9c
Compare
|
@NilsRenaud |
|
Thanks @Tibor17 for your mentoring all along the way, that was great ! Since I'm around, I've 2 questions :
|
NilsRenaud
deleted the
SUREFIRE-1909_replace_add_exports_with_add_opens
branch
|
@NilsRenaud |
|
Backport PR created targeting 2.22.3 : #473 |
This PR fixes : https://issues.apache.org/jira/browse/SUREFIRE-1909
We decided to go with the drop in replacement of
--add-exportswith--add-opens, as suggested in the issue.To add to the background of this issue, a previous PR has been created, introducing the option to use either
add-exportsoradd-opens, the PR is still accessible here : #461To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.