Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SUREFIRE-2009] Refactoring of surefire-junit3. JUnitTestSetExecutor and PojoTestSetExecutor should be stateless. #467

Merged
merged 1 commit into from
Feb 12, 2022

Conversation

Tibor17
Copy link
Contributor

@Tibor17 Tibor17 commented Feb 12, 2022

This is a refactoring of surefire-junit3 I needed to do before completing SUREFIRE-1860. The changes in SUREFIRE-1860 are big and therefore I would like to split them to this refactoring, abstraction in another PR, continue with another PRs regarding implementation of encoder/decoder, SimpleReportEntry. It would give us the opportunity to associate the std/out/err logs with test run id (Thread) and deterministically create the reports and this way fix pending issues (junit5, and simplify the listeners in junit4.7 provider). So I am splitting the work in several pieces.

Following this checklist to help us incorporate your
contribution quickly and easily:

  • [ x] Make sure there is a JIRA issue filed
    for the change (usually before you start working on it). Trivial changes like typos do not
    require a JIRA issue. Your pull request should address just this issue, without
    pulling in other changes.
  • [ x] Each commit in the pull request should have a meaningful subject line and body.
  • [ x] Format the pull request title like [SUREFIRE-XXX] - Fixes bug in ApproximateQuantiles,
    where you replace SUREFIRE-XXX with the appropriate JIRA issue. Best practice
    is to use the JIRA issue title in the pull request title and in the first line of the
    commit message.
  • [x ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • [x ] Run mvn clean install to make sure basic checks pass. A more thorough check will
    be performed on your pull request automatically.
  • You have run the integration tests successfully (mvn -Prun-its clean install).

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

Copy link
Member

@slawekjaranowski slawekjaranowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

JUnit3Provider - filed private TestsToRun testsToRun can be local value.
used only in JUnit3Provider#invoke

in JUnit3Provider#getSuites can be inline

…and PojoTestSetExecutor should be stateless.
@Tibor17 Tibor17 changed the title Refactoring of surefire-junit3. JUnitTestSetExecutor and PojoTestSetExecutor should be stateless. [SUREFIRE-2009] Refactoring of surefire-junit3. JUnitTestSetExecutor and PojoTestSetExecutor should be stateless. Feb 12, 2022
@Tibor17 Tibor17 merged commit 93e0aea into master Feb 12, 2022
@Tibor17 Tibor17 deleted the test-run-id branch February 13, 2022 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants