Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor NamedLockFactorySelector #135

Closed
wants to merge 2 commits into from
Closed

Refactor NamedLockFactorySelector #135

wants to merge 2 commits into from

Conversation

cstamas
Copy link
Member

@cstamas cstamas commented Nov 23, 2021 •
edited
Loading

This PR contains NamedLockFactorySelector related changes:

  • NamedLockFactorySelector made a true component iface+impl (was more like a static helper component). This makes it possible to be replaced in case of need (by some integrator).
  • avoid initing static final variables from system properties (mvnd)
  • refactor source of time parameters used by adapter, they have nothing to do with lock factories. Move it out of selector.
  • adapter time related parameters are sourced from Session by adapter itself

Split for simpler review.

Original changes:

@cstamas
Refactory selectors
5f1043d 
Split the static helper class and make it a component.
@cstamas
Apply time source change
b38d606
@cstamas cstamas requested review from gnodet and michael-o November 23, 2021 14:30
@cstamas cstamas self-assigned this Nov 23, 2021
@cstamas cstamas changed the title Refactory NamedLockFactorySelector Refactor NamedLockFactorySelector Nov 23, 2021
@cstamas cstamas mentioned this pull request Nov 23, 2021
Closed
@asfgit asfgit closed this in b7a5b41 Nov 23, 2021
@cstamas cstamas deleted the selectors branch November 23, 2021 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gnodet gnodet Awaiting requested review from gnodet

@michael-o michael-o Awaiting requested review from michael-o

Assignees

@cstamas cstamas

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@cstamas