[MRELEASE-1077] Support for specifying profiles that can be activated during the prepare phase. #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michael-o
requested changes
Mar 12, 2023
maven-release-plugin/src/main/java/org/apache/maven/plugins/release/PrepareReleaseMojo.java
Show resolved
Hide resolved
maven-release-plugin/src/main/java/org/apache/maven/plugins/release/PrepareReleaseMojo.java
Outdated
Show resolved
Hide resolved
nielsbasjes
force-pushed
the
MRELEASE-1077
branch
from
a0c29a6 to
46214ba
Compare
|
Did a rebase and updated the javadoc as requested. |
michael-o
force-pushed
the
MRELEASE-1077
branch
from
a287004 to
3572ac1
Compare
michael-o
approved these changes
Mar 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some of my projects I have the website for the project as part of the code base.
In those situations I want the website to show the latest released version of the project (I.e. not the current SNAPSHOT that is in the current code base).
To allow updating this version in my website automatically as part of the release process; I would like to have a way to activate the relevant plugins only during the prepare phase of the new release so that I can run the appropriate scripts to change the website.
The implementation is incredibly simple: I only had to attach the getAdditionalProfiles() for the PrepareReleaseMojo to a property. Most of the code is a new integration test.
Following this checklist to help us incorporate your
contribution quickly and easily:
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without
pulling in other changes.
[MJAVADOC-XXX] - Fixes bug in ApproximateQuantiles,where you replace
MJAVADOC-XXXwith the appropriate JIRA issue. Best practiceis to use the JIRA issue title in the pull request title and in the first line of the
commit message.
mvn clean verify -Prun-itsto make sure basic checks pass. A more thorough check willbe performed on your pull request automatically.
If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.
I hereby declare this contribution to be licenced under the Apache License Version 2.0, January 2004
In any other case, please file an Apache Individual Contributor License Agreement.
I'm already PMC for Apache Avro and comitter for Apache Flink