Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MPLUGIN-499] Add deprecate description in parameters table #250

Merged
merged 3 commits into from
Dec 27, 2023
Merged

[MPLUGIN-499] Add deprecate description in parameters table #250

merged 3 commits into from
Dec 27, 2023

Conversation

slawekjaranowski
Copy link
Member

No description provided.

michael-o
michael-o requested changes Dec 26, 2023
View reviewed changes
Copy link
Member

@michael-o michael-o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The full stop after "Deprecated" is on purpose because javadoc(1) does the same: See: https://codehaus-plexus.github.io/plexus-utils/apidocs/org/codehaus/plexus/util/cli/Commandline.html#createArgument(). We wanted to resemblance.

@slawekjaranowski
Copy link
Member Author

ok, next version

@michael-o
Copy link
Member

Checking...

@michael-o
Copy link
Member

Looks better now. I see one difference:
Before:
grafik

After:
grafik

The full stop is gone. Is that on purpose?

@slawekjaranowski
Copy link
Member Author

Missing dot on list of goals is by accident. The same resources is used on goal details page:

image

It was:

Deprecated.:

@slawekjaranowski
Copy link
Member Author

But it is a next issue on list of goals - plugin-info.htm when goal is deprecated we don't have a description.

@michael-o
Copy link
Member

Missing dot on list of goals is by accident. The same resources is used on goal details page:

image

It was:

Deprecated.:

Yes, one fixed the other one broken :-D Can you address?

@michael-o
Copy link
Member

But it is a next issue on list of goals - plugin-info.htm when goal is deprecated we don't have a description.

This isn't right. Deprecation should be first, line break, description.

@slawekjaranowski
Copy link
Member Author

Now it will be as:
image

@michael-o
Copy link
Member

Now it will be as: image

Good. There should be a space between "Deprecated." and the actual text.

Let me test meanwhile.

@slawekjaranowski slawekjaranowski merged commit 7dd3a25 into master Dec 27, 2023
38 checks passed
@slawekjaranowski slawekjaranowski deleted the MPLUGIN-499 branch December 27, 2023 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michael-o michael-o michael-o approved these changes

@kwin kwin Awaiting requested review from kwin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@slawekjaranowski @michael-o