rework ITs to better integrate into skin documentation #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@slawekjaranowski IIRC, you're a GH expert, if you can please configure this branch to run "mvn package site" instead of "mvn site", that would fix the build... |
Comment on lines
27
to
31
| <skin> | ||
| <groupId>org.apache.maven.skins</groupId> | ||
| <artifactId>maven-fluido-skin</artifactId> | ||
| <!-- TODO check with next parent, and next m-site-p --> | ||
| <!-- <version>${project.version}</version> --> | ||
| <version>1.10.0</version> | ||
| <version>${project.version}</version><!-- keep using current version, even if it implies running mvn -Prun-its,reporting install site --> | ||
| </skin> |
There was a problem hiding this comment.
We have IT test which use current build skins.
IMHO project should used latest release version - even more we have the same definition in parent and we needn't here it.
all project should be build by the same standard command
There was a problem hiding this comment.
- having the skin release using an older skin release is not easy to understand
- if we do this, we absolutely need to remove the sample page, because it does not test the current skin release https://maven.apache.org/skins/maven-fluido-skin/sample.html (if I had seen the previous change, I would have -1 it because it creates confusion)
- project is built with the same command as any project = what I fully agree with you is important: it's just the site that has a little unusual requirement for good reasons, given we're releasing a skin, then using it makes sense
|
@hboutemy build fixed |
|
thank you @slawekjaranowski |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see improvement on https://maven.apache.org/skins-archives/maven-fluido-skin-LATEST/sidebar/index.html
vs https://maven.apache.org/skins/maven-fluido-skin/sidebar/index.html
failing GH due to running "mvn site" instead of required "mvn package site"
I'll try to change that...