-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MSHARED-1351] Fix console message when origin is baseDir #93
Conversation
Sent signed the CLA to the required address. |
c0463c0
to
21c6685
Compare
src/main/java/org/apache/maven/shared/filtering/DefaultMavenResourcesFiltering.java
Outdated
Show resolved
Hide resolved
src/main/java/org/apache/maven/shared/filtering/ConsoleHolder.java
Outdated
Show resolved
Hide resolved
21c6685
to
9a95994
Compare
src/test/java/org/apache/maven/shared/filtering/DefaultMavenResourcesFilteringTest.java
Outdated
Show resolved
Hide resolved
9a95994
to
47050bb
Compare
I see Windows failures for path format, I'll see to it later. |
47050bb
to
01f36a7
Compare
Run a customized pipeline on a fork and now Windows passes https://github.com/abelsromero/maven-filtering/actions/runs/7590061551 |
Anything else I should be checking? I don't any have anything identified. |
01f36a7
to
e0e6f20
Compare
Print alternative message replacing the relative origin path by the literal 'base directory'.
Fixed the formatting, is there a way to run the pipeline without manual intervention? |
Hi, all seems green in CI, except for 1 job that was mysteriously canceled. 🤷 Is there anything else that needs my attention in the PR? Thanks |
recently I've fixed similar code here codehaus-plexus/plexus-compiler#364 |
Not sure is the same thing. I don't have context on the other project, but the issue is that |
Following this checklist to help us incorporate your
contribution quickly and easily:
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without
pulling in other changes.
👉 https://issues.apache.org/jira/browse/MSHARED-1351?jql=component%20%3D%20maven-filtering%20
🤞
[MSHARED-XXX] - Fixes bug in ApproximateQuantiles
,where you replace
MSHARED-XXX
with the appropriate JIRA issue. Best practiceis to use the JIRA issue title in the pull request title and in the first line of the
commit message.
👉
[MSHARED-1351] - Fix console message when origin is baseDir
Checks when the path for the message is empty, then replaces that empty with "base dir" to avoid an invalid message.
I considered directly comparing paths
It's more expressive, but that adds extra path processing that are not necessary if we simply check the relativized result.
PS: run
mvn clean verify -Prun-its
to make sure basic checks pass. A more thorough check willbe performed on your pull request automatically.
🆗 The profile does not exist btw, simply run
mvn clean verify
andmvn spotless:apply
to fix formatting.If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.
I hereby declare this contribution to be licensed under the Apache License Version 2.0, January 2004
In any other case, please file an Apache Individual Contributor License Agreement.