Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MSHARED-1290] Fix PropertyUtils cycle detection results in false positives #78

Merged
merged 7 commits into from
Dec 8, 2023
Merged

[MSHARED-1290] Fix PropertyUtils cycle detection results in false positives #78

merged 7 commits into from
Dec 8, 2023

Conversation

wborn
Copy link
Contributor

@wborn wborn commented Jul 21, 2023 •
edited
Loading

This fixes MSHARED-1290 which was caused by apache/maven-shared#17.

@wborn wborn changed the title [MSHARED-1290] PropertyUtils cycle detection results in false positives [MSHARED-1290] Fix PropertyUtils cycle detection results in false positives Jul 21, 2023
elharo
elharo reviewed Oct 22, 2023
View reviewed changes
Copy link
Contributor

@elharo elharo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can the tests be written without inspecting the logger? Logger messages are often side effects that change a lot and shouldn't break unrelated tests

src/test/java/org/apache/maven/shared/filtering/PropertyUtilsTest.java Outdated Show resolved Hide resolved
@wborn
Copy link
Contributor Author

wborn commented Oct 22, 2023

Thanks for having a look! I've addressed your review comments in the new commit @elharo.

@wborn wborn requested a review from elharo October 23, 2023 07:19
@wborn wborn requested a review from elharo October 23, 2023 12:08
@elharo elharo merged commit 811e367 into apache:master Dec 8, 2023
@wborn wborn deleted the MSHARED-1290 branch December 8, 2023 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elharo elharo elharo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wborn @elharo