[DOXIA-534] Migrate logging to Sl4j #5

slachiewicz · 2017-11-25T16:25:19Z

Please check.

Current build fails with cirr error - due to interfaces change.

michael-o · 2017-11-25T17:07:11Z

doxia-modules/doxia-module-fo/pom.xml

@@ -78,7 +72,7 @@ under the License.
    <dependency>
      <groupId>commons-collections</groupId>
      <artifactId>commons-collections</artifactId>
-      <version>3.2.1</version>
+      <version>3.2.2</version>


This should be a seperate issue if not necesary for this PR.

michael-o · 2017-11-25T17:09:06Z

pom.xml

      </dependency>
    </dependencies>
  </dependencyManagement>
  <dependencies>
    <dependency>
      <groupId>junit</groupId>
      <artifactId>junit</artifactId>
-      <version>4.11</version>
+      <version>4.12</version>


Same as commons-collections

ok, will be diffret pull - only with dependences

michael-o · 2017-11-25T17:10:04Z

...-modules/doxia-module-fo/src/main/java/org/apache/maven/doxia/module/fo/FoAggregateSink.java

@@ -1322,12 +1322,12 @@ private SinkEventAttributeSet getGraphicsAttributes( String logo )
        }
        catch ( IOException e )
        {
-            getLog().debug( e );
+            getLog().debug( e.getMessage() );


Leave it as e, SFL4J and backends will do the rest for us.

there is no constructor with Exception, i will change to e.getMessage(), e

@slachiewicz @michael-o Proper code here would be getLog().debug("", e). That assumes you want the full stack trace and not just the message.

michael-o · 2017-11-25T17:10:47Z

@hboutemy Looks good to me. Tests pending...

hboutemy · 2017-11-25T17:29:43Z

I'm not in favor of removing doxia-logging: deprecating and modifying it to use slf4j would be more compatible
I know there are not so much Doxia extensions in the wild: there is at least asciidoc I know of. I didn't check, but would be useful to not break this one at least

michael-o · 2017-11-25T17:47:58Z

Why not deprecate in 1.8 and remove with 2.0?

hboutemy · 2017-11-25T18:24:21Z

+1

michael-o · 2017-11-25T19:23:54Z

@slachiewicz Can you spawn another ticket and create a new PR? We will leave this one open.

slachiewicz · 2017-11-25T20:34:09Z

There is almost no usage of logging in Doxia, so any extention needs only to remove one call.

slachiewicz · 2018-02-11T18:32:51Z

New version with deprecation in #8

abelsromero · 2020-06-29T20:30:19Z

I'm not in favor of removing doxia-logging: deprecating and modifying it to use slf4j would be more compatible
I know there are not so much Doxia extensions in the wild: there is at least asciidoc I know of. I didn't check, but would be useful to not break this one at least

I mantain the asciidoctor extension and I am fine with removing logging-api. In fact we have problems sharing code between the our normal Mojo and the doxia parser because one uses "maven.plugin.logging.Log" and the other "maven.doxia.logging.Log". Moving doxia to Sl4j won't fix it 100%, but will be one step closer.

* Bumped versions * Migrated site module to slf4j since apache/maven-doxia#5 * Reorder constructor args in AsciidoctorDoxiaParserModule

* Bump Doxia to 2.0.0-M1 * Leave note in docs for release * Use SLF4J in site module (apache/maven-doxia#5) * Reorder constructor args in AsciidoctorDoxiaParserModule

* Bump Doxia to 2.0.0-M1 * Leave note in docs for release * Use SLF4J in site module (apache/maven-doxia#5) * Reorder constructor args in AsciidoctorDoxiaParserModule Fixes asciidoctor#578

* Bump Doxia to 2.0.0-M1 * Leave note in docs for release * Use SLF4J in site module (apache/maven-doxia#5) * Reorder constructor args in AsciidoctorDoxiaParserModule * Update IT test site.xml Fixes asciidoctor#578

* Bump Doxia to 2.0.0-M1 * Leave note in docs for release * Use SLF4J in site module (apache/maven-doxia#5) * Reorder constructor args in AsciidoctorDoxiaParserModule * Update IT test site.xml Fixes #578

* Bump Doxia to 2.0.0-M1 * Leave note in docs for release * Use SLF4J in site module (apache/maven-doxia#5) * Reorder constructor args in AsciidoctorDoxiaParserModule * Update IT test site.xml Fixes asciidoctor#578

* Bump Doxia to 2.0.0-M1 * Leave note in docs for release * Use SLF4J in site module (apache/maven-doxia#5) * Reorder constructor args in AsciidoctorDoxiaParserModule * Update IT test site.xml Fixes asciidoctor#578 Bump doxia-core to v2.0.0-M3 (asciidoctor#590) * Bump maven-site-plugin in IT to v4.0.0-M3 * Add skin to IT (mandatory since v4.0.0-M2) Bump maven-site and doxia to latests * maven-site-plugin v4.0.0-M8 * doxia & fluido skin 2.0.0-M6 * Sections and tables updated Bump maven-site to M13, Doxia to M8

* Use SLF4J in site module (apache/maven-doxia#5) * Unify Doxia versions in parent pom * Use same Doxia version for doxia-core and doxia-site-renderer * Use javax.inject.Named instead of custom Plexus * Add skin to IT (mandatory since v4.0.0-M2) * Bump maven-site-plugin, doxia, Fluido skins

michael-o reviewed Nov 25, 2017

View reviewed changes

Migrate to slf4j

12ef323

slachiewicz closed this Feb 11, 2018

slachiewicz deleted the feature/DOXIA-534-logging branch February 11, 2018 18:35

abelsromero added a commit to abelsromero/asciidoctor-maven-plugin that referenced this pull request May 19, 2022

WIP: working poc

ab86424

* Bumped versions * Migrated site module to slf4j since apache/maven-doxia#5 * Reorder constructor args in AsciidoctorDoxiaParserModule

abelsromero added a commit to abelsromero/asciidoctor-maven-plugin that referenced this pull request Jun 12, 2022

WIP: working poc

8dba67e

* Bumped versions * Migrated site module to slf4j since apache/maven-doxia#5 * Reorder constructor args in AsciidoctorDoxiaParserModule

abelsromero added a commit to abelsromero/asciidoctor-maven-plugin that referenced this pull request Jun 12, 2022

WIP: working poc

6243020

* Bumped versions * Migrated site module to slf4j since apache/maven-doxia#5 * Reorder constructor args in AsciidoctorDoxiaParserModule

abelsromero added a commit to abelsromero/asciidoctor-maven-plugin that referenced this pull request Jun 12, 2022

WIP: working poc

8bc2d13

* Bumped versions * Migrated site module to slf4j since apache/maven-doxia#5 * Reorder constructor args in AsciidoctorDoxiaParserModule

abelsromero mentioned this pull request Jun 12, 2022

Make plugin compatible with maven-site-plugin 4.0.0-M1 asciidoctor/asciidoctor-maven-plugin#585

Merged

8 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[DOXIA-534] Migrate logging to Sl4j #5

[DOXIA-534] Migrate logging to Sl4j #5

slachiewicz commented Nov 25, 2017

michael-o Nov 25, 2017

michael-o Nov 25, 2017

slachiewicz Nov 25, 2017

michael-o Nov 25, 2017

slachiewicz Nov 25, 2017

hazendaz Dec 31, 2017

michael-o commented Nov 25, 2017

hboutemy commented Nov 25, 2017

michael-o commented Nov 25, 2017

hboutemy commented Nov 25, 2017

michael-o commented Nov 25, 2017

slachiewicz commented Nov 25, 2017

slachiewicz commented Feb 11, 2018

abelsromero commented Jun 29, 2020

[DOXIA-534] Migrate logging to Sl4j #5

[DOXIA-534] Migrate logging to Sl4j #5

Conversation

slachiewicz commented Nov 25, 2017

michael-o Nov 25, 2017

Choose a reason for hiding this comment

michael-o Nov 25, 2017

Choose a reason for hiding this comment

slachiewicz Nov 25, 2017

Choose a reason for hiding this comment

michael-o Nov 25, 2017

Choose a reason for hiding this comment

slachiewicz Nov 25, 2017

Choose a reason for hiding this comment

hazendaz Dec 31, 2017

Choose a reason for hiding this comment

michael-o commented Nov 25, 2017

hboutemy commented Nov 25, 2017

michael-o commented Nov 25, 2017

hboutemy commented Nov 25, 2017

michael-o commented Nov 25, 2017

slachiewicz commented Nov 25, 2017

slachiewicz commented Feb 11, 2018

abelsromero commented Jun 29, 2020