-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MDEPLOY-295] Drop MAT #25
Conversation
|
||
private RemoteRepository getRemoteRepository( ArtifactRepository remoteRepository ) | ||
{ | ||
RemoteRepository aetherRepo = RepositoryUtils.toRepo( remoteRepository ); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we still use the old term aether
?
if ( count + 1 < retryFailedDeploymentCounter ) | ||
{ | ||
getLog().warn( "Encountered issue during deployment: " + e.getLocalizedMessage() ); | ||
getLog().debug( e.getMessage() ); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Honestly, just use warn with e
and that's it. No brain magic.
@@ -137,12 +135,6 @@ | |||
@Parameter( property = "maven.deploy.skip", defaultValue = "false" ) | |||
private String skip = Boolean.FALSE.toString(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, why is that a string :-D
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
0
see comment
import org.apache.maven.rtinfo.RuntimeInformation; | ||
import org.eclipse.aether.RepositorySystem; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and soon we will change to org.apache.maven package... ?
maybe think in the other way… why we have not yet change package from maven-resolver?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unsure what you talk about:
- if you refer to package change for resolver, yes, it will happen, somewhere around Maven 5, but that will not affect you, as
- Maven 4 introduces new API and seals Maven internals off from plugins, hence from 4.1 or so, plugin will not "tamper" with resolver and other internal things of Maven anymore, will have to go for Maven API
- in short, resolver package change, if that's you refer to will NOT affect you, and if the "soon we will change to" refers to Maven API 4.x, is still WIP and of course non existent in Maven 3.x line.
-0 same comment as here apache/maven-install-plugin#31 (comment) |
@cstamas Please process my comments |
Superseded by #26 |
interesting to close this one and quickly open and merge (in less than 2 hours) a new one without without taking care of comments.... |
Now that Maven is 3.2.5 no need for MAT anymore.
https://issues.apache.org/jira/browse/MDEPLOY-295