Skip to content

Commit

Permalink
[MDEP-939] Lock down classifier in dependency:sources goal
Browse files Browse the repository at this point in the history
This closes #409
  • Loading branch information
michael-o committed Jun 8, 2024
1 parent 9fd4ed5 commit 04c3216
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 16 deletions.
6 changes: 4 additions & 2 deletions src/it/projects/sources/test.properties
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,9 @@
# to you under the Apache License, Version 2.0 (the
# "License"); you may not use this file except in compliance
# with the License. You may obtain a copy of the License at
#
#
# http://www.apache.org/licenses/LICENSE-2.0
#
#
# Unless required by applicable law or agreed to in writing,
# software distributed under the License is distributed on an
# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
Expand All @@ -16,3 +16,5 @@
# under the License.

outputFile = target/resolved.txt
# This is intentional to prove that no classifier is passed (read-only value)
classifier = foo
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,9 @@
*/
package org.apache.maven.plugins.dependency.resolvers;

import org.apache.maven.plugin.MojoExecutionException;
import org.apache.maven.plugins.annotations.LifecyclePhase;
import org.apache.maven.plugins.annotations.Mojo;
import org.apache.maven.plugins.annotations.Parameter;
import org.apache.maven.plugins.annotations.ResolutionScope;

/**
Expand All @@ -36,19 +36,10 @@
threadSafe = true)
public class ResolveDependencySourcesMojo extends ResolveDependenciesMojo {

private static final String SOURCE_CLASSIFIER = "sources";
private static final String SOURCES_CLASSIFIER = "sources";

/**
* Main entry into mojo. Gets the list of dependencies and iterates through resolving the source jars.
*
* @throws MojoExecutionException with a message if an error occurs.
*/
@Override
protected void doExecute() throws MojoExecutionException {
if (this.classifier == null || this.classifier.isEmpty()) {
this.classifier = SOURCE_CLASSIFIER;
}

super.doExecute();
@Parameter(name = "classifier", defaultValue = SOURCES_CLASSIFIER, readonly = true)
public void setClassifier(String classifier) {
this.classifier = classifier;
}
}

0 comments on commit 04c3216

Please sign in to comment.